Re: [PULL 00/13] target: Add the Renesas RX architecture

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/13] target: Add the Renesas RX architecture
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
535cf68 Add rx-softmmu
a4dec27 target/rx: Dump bytes for each insn during disassembly
d7598a8 target/rx: Collect all bytes during disassembly
dcd1fc4 target/rx: Emit all disassembly in one prt()
1f2f350 target/rx: Use prt_ldmi for XCHG_mr disassembly
732d148 target/rx: Replace operand with prt_ldmi in disassembler
4986f2e target/rx: Disassemble rx_index_addr into a string
77fa86b target/rx: RX disassembler
a5dbc2b target/rx: CPU definitions
0ca6b46 target/rx: TCG helpers
5dc4bed target/rx: TCG translation
e7b2b77 MAINTAINERS: Add entry for the Renesas RX architecture
834d435 hw/registerfields.h: Add 8bit and 16bit register macros

=== OUTPUT BEGIN ===
1/13 Checking commit 834d435694f8 (hw/registerfields.h: Add 8bit and 16bit 
register macros)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#29: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                   \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#33: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 48 lines checked

Patch 1/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/13 Checking commit e7b2b77fbea2 (MAINTAINERS: Add entry for the Renesas RX 
architecture)
3/13 Checking commit 5dc4beddbcc7 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 3/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/13 Checking commit 0ca6b46ea8d2 (target/rx: TCG helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 4/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/13 Checking commit a5dbc2bd59fe (target/rx: CPU definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 706 lines checked

Patch 5/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/13 Checking commit 77fa86be9187 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 6/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/13 Checking commit 4986f2ec7901 (target/rx: Disassemble rx_index_addr into a 
string)
8/13 Checking commit 732d148c748e (target/rx: Replace operand with prt_ldmi in 
disassembler)
9/13 Checking commit 1f2f350c5ea1 (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
10/13 Checking commit dcd1fc42e0a9 (target/rx: Emit all disassembly in one 
prt())
11/13 Checking commit d7598a82bf6b (target/rx: Collect all bytes during 
disassembly)
12/13 Checking commit a4dec27f7f50 (target/rx: Dump bytes for each insn during 
disassembly)
13/13 Checking commit 535cf68782f7 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 13/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden