[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/13] target/rx: Dump bytes for each insn during disassembly
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 12/13] target/rx: Dump bytes for each insn during disassembly |
Date: |
Tue, 17 Mar 2020 17:36:15 +0100 |
From: Richard Henderson <address@hidden>
There are so many different forms of each RX instruction
that it will be very useful to be able to look at the bytes
to see on which path a bug may lie.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Yoshinori Sato <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Acked-by: Richard Henderson <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
target/rx/disas.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/target/rx/disas.c b/target/rx/disas.c
index dcfb7baf99..6dee7a0342 100644
--- a/target/rx/disas.c
+++ b/target/rx/disas.c
@@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d)
/* Include the auto-generated decoder. */
#include "decode.inc.c"
-#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__)
+static void dump_bytes(DisasContext *ctx)
+{
+ int i, len = ctx->len;
+
+ for (i = 0; i < len; ++i) {
+ ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]);
+ }
+ ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t');
+}
+
+#define prt(...) \
+ do { \
+ dump_bytes(ctx); \
+ ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \
+ } while (0)
#define RX_MEMORY_BYTE 0
#define RX_MEMORY_WORD 1
--
2.21.1
- [PULL 00/13] target: Add the Renesas RX architecture, Philippe Mathieu-Daudé, 2020/03/17
- [PULL 01/13] hw/registerfields.h: Add 8bit and 16bit register macros, Philippe Mathieu-Daudé, 2020/03/17
- [PULL 02/13] MAINTAINERS: Add entry for the Renesas RX architecture, Philippe Mathieu-Daudé, 2020/03/17
- [PULL 04/13] target/rx: TCG helpers, Philippe Mathieu-Daudé, 2020/03/17
- [PULL 07/13] target/rx: Disassemble rx_index_addr into a string, Philippe Mathieu-Daudé, 2020/03/17
- [PULL 09/13] target/rx: Use prt_ldmi for XCHG_mr disassembly, Philippe Mathieu-Daudé, 2020/03/17
- [PULL 05/13] target/rx: CPU definitions, Philippe Mathieu-Daudé, 2020/03/17
- [PULL 08/13] target/rx: Replace operand with prt_ldmi in disassembler, Philippe Mathieu-Daudé, 2020/03/17
- [PULL 12/13] target/rx: Dump bytes for each insn during disassembly,
Philippe Mathieu-Daudé <=
- [PULL 10/13] target/rx: Emit all disassembly in one prt(), Philippe Mathieu-Daudé, 2020/03/17
- [PULL 11/13] target/rx: Collect all bytes during disassembly, Philippe Mathieu-Daudé, 2020/03/17
- [PULL 06/13] target/rx: RX disassembler, Philippe Mathieu-Daudé, 2020/03/17
- [PULL 13/13] Add rx-softmmu, Philippe Mathieu-Daudé, 2020/03/17
- [PULL 03/13] target/rx: TCG translation, Philippe Mathieu-Daudé, 2020/03/17
- Re: [PULL 00/13] target: Add the Renesas RX architecture, no-reply, 2020/03/17
- Re: [PULL 00/13] target: Add the Renesas RX architecture, no-reply, 2020/03/17
- Re: [PULL 00/13] target: Add the Renesas RX architecture, Philippe Mathieu-Daudé, 2020/03/18