Re: [PULL 00/38] Linux user for 5.0 patches

qemu-devel
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/38] Linux user for 5.0 patches

From:	no-reply
Subject:	Re: [PULL 00/38] Linux user for 5.0 patches
Date:	Mon, 16 Mar 2020 19:13:07 -0700 (PDT)
Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/38] Linux user for 5.0 patches
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
1bc4578 linux-user, openrisc: sync syscall numbers with kernel v5.5
275bdae linux-user, nios2: sync syscall numbers with kernel v5.5
d7f7755 linux-user, aarch64: sync syscall numbers with kernel v5.5
d274711 scripts: add a script to generate syscall_nr.h
b3e9680 linux-user,mips: update syscall-args-o32.c.inc
e26a1be linux-user,mips: move content of mips_syscall_args
e1cac57 linux-user: update syscall.tbl from linux 0bf999f9c5e7
3a51017 linux-user, scripts: add a script to update syscall.tbl
2c2876d linux-user, mips64: add syscall table generation support
20353f9 linux-user, mips: add syscall table generation support
2760210 linux-user, x86_64: add syscall table generation support
c280817 linux-user, i386: add syscall table generation support
1458029 linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl
9478b8e linux-user, sparc, sparc64: add syscall table generation support
1553992 linux-user, s390x: add syscall table generation support
fbd36b7 linux-user, s390x: remove syscall definitions for !TARGET_S390X
3c686ee linux-user, ppc: add syscall table generation support
76525c6 linux-user, arm: add syscall table generation support
9402b9f linux-user, microblaze: add syscall table generation support
97fee9a linux-user, sh4: add syscall table generation support
ef7c323 linux-user, xtensa: add syscall table generation support
a1150d5 linux-user, m68k: add syscall table generation support
ceb7559 linux-user, hppa: add syscall table generation support
b7160c7 linux-user, alpha: add syscall table generation support
7900d95 linux-user: introduce parameters to generate syscall_nr.h
02ba121 linux-user/riscv: Update the syscall_nr's to the 5.5 kernel
19eb9e3 linux-user: Support futex_time64
b9b6629 linux-user/syscall: Add support for clock_gettime64/clock_settime64
4ebab6c linux-user: Protect more syscalls
baa0e71 linux-user: Update TASK_UNMAPPED_BASE for aarch64
4fcfda0 linux-user: fix socket() strace
13110bd linux-user: do prlimit selectively
a99c994 linux-user: Add AT_EXECFN auxval
b006c5c linux-user: Flush out implementation of gettimeofday
6bdd12d linux-user: Add x86_64 vsyscall page to /proc/self/maps
e65d100 linux-user/i386: Emulate x86_64 vsyscalls
e90a705 linux-user/i386: Split out gen_signal
8703c17 target/i386: Renumber EXCP_SYSCALL

=== OUTPUT BEGIN ===
1/38 Checking commit 8703c1770f3e (target/i386: Renumber EXCP_SYSCALL)
2/38 Checking commit e90a7057d9fa (linux-user/i386: Split out gen_signal)
3/38 Checking commit e65d100c17e5 (linux-user/i386: Emulate x86_64 vsyscalls)
4/38 Checking commit 6bdd12d66dcb (linux-user: Add x86_64 vsyscall page to 
/proc/self/maps)
5/38 Checking commit b006c5c97f9e (linux-user: Flush out implementation of 
gettimeofday)
6/38 Checking commit a99c994a9a7a (linux-user: Add AT_EXECFN auxval)
7/38 Checking commit 13110bd183ea (linux-user: do prlimit selectively)
8/38 Checking commit 4fcfda0cbd8a (linux-user: fix socket() strace)
9/38 Checking commit baa0e71093cc (linux-user: Update TASK_UNMAPPED_BASE for 
aarch64)
10/38 Checking commit 4ebab6c489e6 (linux-user: Protect more syscalls)
11/38 Checking commit b9b6629bd329 (linux-user/syscall: Add support for 
clock_gettime64/clock_settime64)
12/38 Checking commit 19eb9e3d100b (linux-user: Support futex_time64)
WARNING: architecture specific defines should be avoided
#26: FILE: linux-user/syscall.c:248:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#29: FILE: linux-user/syscall.c:251:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#40: FILE: linux-user/syscall.c:303:
+#if (defined(TARGET_NR_futex) && defined(__NR_futex)) || \

WARNING: architecture specific defines should be avoided
#46: FILE: linux-user/syscall.c:309:
+#if (defined(TARGET_NR_futex_time64) && defined(__NR_futex_teim64))

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
              ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                               ^

ERROR: space required after that ',' (ctx:OxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                  ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                          ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                       ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

WARNING: architecture specific defines should be avoided
#58: FILE: linux-user/syscall.c:776:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#62: FILE: linux-user/syscall.c:780:
+#if defined(__NR_futex_time64)

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                               ^

ERROR: space required after that ',' (ctx:OxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                      ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                              ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                    ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                               ^

WARNING: architecture specific defines should be avoided
#87: FILE: linux-user/syscall.c:6930:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#93: FILE: linux-user/syscall.c:6936:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#99: FILE: linux-user/syscall.c:6942:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#112: FILE: linux-user/syscall.c:6955:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#117: FILE: linux-user/syscall.c:6960:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#124: FILE: linux-user/syscall.c:6967:
+#if defined(__NR_futex)

WARNING: line over 80 characters
#171: FILE: linux-user/syscall.c:7030:
+static int do_futex_time64(target_ulong uaddr, int op, int val, target_ulong 
timeout,

WARNING: Block comments use a leading /* on a separate line
#177: FILE: linux-user/syscall.c:7036:
+    /* ??? We assume FUTEX_* constants are the same on both host

WARNING: Block comments use * on subsequent lines
#178: FILE: linux-user/syscall.c:7037:
+    /* ??? We assume FUTEX_* constants are the same on both host
+       and target.  */

WARNING: Block comments use a trailing */ on a separate line
#178: FILE: linux-user/syscall.c:7037:
+       and target.  */

WARNING: Block comments use a leading /* on a separate line
#202: FILE: linux-user/syscall.c:7061:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the

WARNING: Block comments use * on subsequent lines
#203: FILE: linux-user/syscall.c:7062:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the
+           TIMEOUT parameter is interpreted as a uint32_t by the kernel.

WARNING: Block comments use a trailing */ on a separate line
#206: FILE: linux-user/syscall.c:7065:
+           since it's not compared to guest memory.  */

total: 24 errors, 19 warnings, 212 lines checked

Patch 12/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/38 Checking commit 02ba121e2143 (linux-user/riscv: Update the syscall_nr's 
to the 5.5 kernel)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 898 lines checked

Patch 13/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/38 Checking commit 7900d95851ba (linux-user: introduce parameters to 
generate syscall_nr.h)
15/38 Checking commit b7160c722d10 (linux-user, alpha: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 536 lines checked

Patch 15/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/38 Checking commit ceb755998c50 (linux-user, hppa: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 491 lines checked

Patch 16/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/38 Checking commit a1150d5fc852 (linux-user, m68k: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 493 lines checked

Patch 17/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/38 Checking commit ef7c32304b9d (linux-user, xtensa: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 464 lines checked

Patch 18/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/38 Checking commit 97fee9aed4cb (linux-user, sh4: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 19/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/38 Checking commit 9402b9fe0c51 (linux-user, microblaze: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 501 lines checked

Patch 20/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/38 Checking commit 76525c62474d (linux-user, arm: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62: 
new file mode 100644

total: 0 errors, 1 warnings, 531 lines checked

Patch 21/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/38 Checking commit 3c686ee30c6c (linux-user, ppc: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

total: 0 errors, 1 warnings, 608 lines checked

Patch 22/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/38 Checking commit fbd36b79f0f2 (linux-user, s390x: remove syscall 
definitions for !TARGET_S390X)
24/38 Checking commit 1553992d2738 (linux-user, s390x: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 498 lines checked

Patch 24/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/38 Checking commit 9478b8eda12b (linux-user, sparc, sparc64: add syscall 
table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

total: 0 errors, 1 warnings, 1072 lines checked

Patch 25/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/38 Checking commit 14580297fe50 (linux-user, x86_64, i386: cleanup 
TARGET_NR_arch_prctl)
27/38 Checking commit c280817ad0a8 (linux-user, i386: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 27/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/38 Checking commit 2760210c4f0b (linux-user, x86_64: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 455 lines checked

Patch 28/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/38 Checking commit 20353f9a4a27 (linux-user, mips: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

total: 0 errors, 1 warnings, 488 lines checked

Patch 29/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/38 Checking commit 2c2876d5c79f (linux-user, mips64: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 802 lines checked

Patch 30/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/38 Checking commit 3a51017c7c7b (linux-user, scripts: add a script to update 
syscall.tbl)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 56 lines checked

Patch 31/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
32/38 Checking commit e1cac57a0539 (linux-user: update syscall.tbl from linux 
0bf999f9c5e7)
33/38 Checking commit e26a1beca0f9 (linux-user,mips: move content of 
mips_syscall_args)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#470: 
new file mode 100644

total: 0 errors, 1 warnings, 886 lines checked

Patch 33/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/38 Checking commit b3e96808bbe7 (linux-user,mips: update 
syscall-args-o32.c.inc)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#908: 
new file mode 100755

total: 0 errors, 1 warnings, 938 lines checked

Patch 34/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/38 Checking commit d2747119be6a (scripts: add a script to generate 
syscall_nr.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 109 lines checked

Patch 35/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/38 Checking commit d7f77556e91c (linux-user, aarch64: sync syscall numbers 
with kernel v5.5)
37/38 Checking commit 275bdae45e8c (linux-user, nios2: sync syscall numbers 
with kernel v5.5)
38/38 Checking commit 1bc45787f51d (linux-user, openrisc: sync syscall numbers 
with kernel v5.5)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
[Prev in Thread]
Current Thread
[Next in Thread]
[PULL 34/38] linux-user,mips: update syscall-args-o32.c.inc, (continued)
- [PULL 34/38] linux-user,mips: update syscall-args-o32.c.inc, Laurent Vivier, 2020/03/16
- [PULL 28/38] linux-user, x86_64: add syscall table generation support, Laurent Vivier, 2020/03/16
- [PULL 24/38] linux-user, s390x: add syscall table generation support, Laurent Vivier, 2020/03/16
- [PULL 38/38] linux-user, openrisc: sync syscall numbers with kernel v5.5, Laurent Vivier, 2020/03/16
- Re: [PULL 00/38] Linux user for 5.0 patches, Peter Maydell, 2020/03/16
  - Re: [PULL 00/38] Linux user for 5.0 patches, Laurent Vivier, 2020/03/17
- Re: [PULL 00/38] Linux user for 5.0 patches, no-reply, 2020/03/16
- Re: [PULL 00/38] Linux user for 5.0 patches, no-reply, 2020/03/16
- Re: [PULL 00/38] Linux user for 5.0 patches, no-reply, 2020/03/16
- Re: [PULL 00/38] Linux user for 5.0 patches, no-reply, 2020/03/16
- Re: [PULL 00/38] Linux user for 5.0 patches, no-reply <=
Prev by Date: Re: [PULL 00/38] Linux user for 5.0 patches
Next by Date: Re: [PATCH V2] vhost: correctly turn on VIRTIO_F_IOMMU_PLATFORM
Previous by thread: Re: [PULL 00/38] Linux user for 5.0 patches
Next by thread: Re: [PULL 04/31] util/async: make bh_aio_poll() O(1)
Index(es):
- Date
- Thread