Re: [PULL 00/38] Linux user for 5.0 patches

qemu-devel
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/38] Linux user for 5.0 patches

From:	no-reply
Subject:	Re: [PULL 00/38] Linux user for 5.0 patches
Date:	Mon, 16 Mar 2020 18:09:42 -0700 (PDT)
Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/38] Linux user for 5.0 patches
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
10fafb1 linux-user, openrisc: sync syscall numbers with kernel v5.5
6782f6a linux-user, nios2: sync syscall numbers with kernel v5.5
9f6200d linux-user, aarch64: sync syscall numbers with kernel v5.5
45ee667 scripts: add a script to generate syscall_nr.h
1f2ea4d linux-user,mips: update syscall-args-o32.c.inc
d23d2a1 linux-user,mips: move content of mips_syscall_args
f41ff3c linux-user: update syscall.tbl from linux 0bf999f9c5e7
19a0e30 linux-user, scripts: add a script to update syscall.tbl
4eec500 linux-user, mips64: add syscall table generation support
aeec810 linux-user, mips: add syscall table generation support
9815b8d linux-user, x86_64: add syscall table generation support
2695951 linux-user, i386: add syscall table generation support
1459c30 linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl
4158bb5 linux-user, sparc, sparc64: add syscall table generation support
91ebd50 linux-user, s390x: add syscall table generation support
b456bac linux-user, s390x: remove syscall definitions for !TARGET_S390X
9a58453 linux-user, ppc: add syscall table generation support
01a0d3e linux-user, arm: add syscall table generation support
5c48386 linux-user, microblaze: add syscall table generation support
c908a6a linux-user, sh4: add syscall table generation support
4a37ce6 linux-user, xtensa: add syscall table generation support
e6f088c linux-user, m68k: add syscall table generation support
b3099a5 linux-user, hppa: add syscall table generation support
550b771 linux-user, alpha: add syscall table generation support
af30485 linux-user: introduce parameters to generate syscall_nr.h
136c2bf linux-user/riscv: Update the syscall_nr's to the 5.5 kernel
b2dec49 linux-user: Support futex_time64
44d988e linux-user/syscall: Add support for clock_gettime64/clock_settime64
96402ae linux-user: Protect more syscalls
8b3e85d linux-user: Update TASK_UNMAPPED_BASE for aarch64
0cbf17e linux-user: fix socket() strace
91bd410 linux-user: do prlimit selectively
403d5bc linux-user: Add AT_EXECFN auxval
06b7595 linux-user: Flush out implementation of gettimeofday
4050585 linux-user: Add x86_64 vsyscall page to /proc/self/maps
1db8bf7 linux-user/i386: Emulate x86_64 vsyscalls
f47d45b linux-user/i386: Split out gen_signal
34bb353 target/i386: Renumber EXCP_SYSCALL

=== OUTPUT BEGIN ===
1/38 Checking commit 34bb353a89ec (target/i386: Renumber EXCP_SYSCALL)
2/38 Checking commit f47d45b3bace (linux-user/i386: Split out gen_signal)
3/38 Checking commit 1db8bf765b39 (linux-user/i386: Emulate x86_64 vsyscalls)
4/38 Checking commit 405058564933 (linux-user: Add x86_64 vsyscall page to 
/proc/self/maps)
5/38 Checking commit 06b75956b14e (linux-user: Flush out implementation of 
gettimeofday)
6/38 Checking commit 403d5bca8b6d (linux-user: Add AT_EXECFN auxval)
7/38 Checking commit 91bd41044ad3 (linux-user: do prlimit selectively)
8/38 Checking commit 0cbf17e17283 (linux-user: fix socket() strace)
9/38 Checking commit 8b3e85d562b1 (linux-user: Update TASK_UNMAPPED_BASE for 
aarch64)
10/38 Checking commit 96402ae791e6 (linux-user: Protect more syscalls)
11/38 Checking commit 44d988e75f99 (linux-user/syscall: Add support for 
clock_gettime64/clock_settime64)
12/38 Checking commit b2dec497276d (linux-user: Support futex_time64)
WARNING: architecture specific defines should be avoided
#26: FILE: linux-user/syscall.c:248:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#29: FILE: linux-user/syscall.c:251:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#40: FILE: linux-user/syscall.c:303:
+#if (defined(TARGET_NR_futex) && defined(__NR_futex)) || \

WARNING: architecture specific defines should be avoided
#46: FILE: linux-user/syscall.c:309:
+#if (defined(TARGET_NR_futex_time64) && defined(__NR_futex_teim64))

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
              ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                               ^

ERROR: space required after that ',' (ctx:OxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                  ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                          ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                       ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

WARNING: architecture specific defines should be avoided
#58: FILE: linux-user/syscall.c:776:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#62: FILE: linux-user/syscall.c:780:
+#if defined(__NR_futex_time64)

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                               ^

ERROR: space required after that ',' (ctx:OxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                      ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                              ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                    ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                               ^

WARNING: architecture specific defines should be avoided
#87: FILE: linux-user/syscall.c:6930:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#93: FILE: linux-user/syscall.c:6936:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#99: FILE: linux-user/syscall.c:6942:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#112: FILE: linux-user/syscall.c:6955:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#117: FILE: linux-user/syscall.c:6960:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#124: FILE: linux-user/syscall.c:6967:
+#if defined(__NR_futex)

WARNING: line over 80 characters
#171: FILE: linux-user/syscall.c:7030:
+static int do_futex_time64(target_ulong uaddr, int op, int val, target_ulong 
timeout,

WARNING: Block comments use a leading /* on a separate line
#177: FILE: linux-user/syscall.c:7036:
+    /* ??? We assume FUTEX_* constants are the same on both host

WARNING: Block comments use * on subsequent lines
#178: FILE: linux-user/syscall.c:7037:
+    /* ??? We assume FUTEX_* constants are the same on both host
+       and target.  */

WARNING: Block comments use a trailing */ on a separate line
#178: FILE: linux-user/syscall.c:7037:
+       and target.  */

WARNING: Block comments use a leading /* on a separate line
#202: FILE: linux-user/syscall.c:7061:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the

WARNING: Block comments use * on subsequent lines
#203: FILE: linux-user/syscall.c:7062:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the
+           TIMEOUT parameter is interpreted as a uint32_t by the kernel.

WARNING: Block comments use a trailing */ on a separate line
#206: FILE: linux-user/syscall.c:7065:
+           since it's not compared to guest memory.  */

total: 24 errors, 19 warnings, 212 lines checked

Patch 12/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/38 Checking commit 136c2bf1d6c5 (linux-user/riscv: Update the syscall_nr's 
to the 5.5 kernel)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 898 lines checked

Patch 13/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/38 Checking commit af304858050f (linux-user: introduce parameters to 
generate syscall_nr.h)
15/38 Checking commit 550b77128c2e (linux-user, alpha: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 536 lines checked

Patch 15/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/38 Checking commit b3099a5f69ea (linux-user, hppa: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 491 lines checked

Patch 16/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/38 Checking commit e6f088c503bf (linux-user, m68k: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 493 lines checked

Patch 17/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/38 Checking commit 4a37ce61da27 (linux-user, xtensa: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 464 lines checked

Patch 18/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/38 Checking commit c908a6ade856 (linux-user, sh4: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 19/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/38 Checking commit 5c48386eb066 (linux-user, microblaze: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 501 lines checked

Patch 20/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/38 Checking commit 01a0d3e7ba67 (linux-user, arm: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62: 
new file mode 100644

total: 0 errors, 1 warnings, 531 lines checked

Patch 21/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/38 Checking commit 9a5845309428 (linux-user, ppc: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

total: 0 errors, 1 warnings, 608 lines checked

Patch 22/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/38 Checking commit b456bac3f69e (linux-user, s390x: remove syscall 
definitions for !TARGET_S390X)
24/38 Checking commit 91ebd50eb411 (linux-user, s390x: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 498 lines checked

Patch 24/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/38 Checking commit 4158bb5c6c01 (linux-user, sparc, sparc64: add syscall 
table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

total: 0 errors, 1 warnings, 1072 lines checked

Patch 25/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/38 Checking commit 1459c30a1c94 (linux-user, x86_64, i386: cleanup 
TARGET_NR_arch_prctl)
27/38 Checking commit 2695951d66ff (linux-user, i386: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 27/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/38 Checking commit 9815b8d388bf (linux-user, x86_64: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 455 lines checked

Patch 28/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/38 Checking commit aeec8106c76f (linux-user, mips: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

total: 0 errors, 1 warnings, 488 lines checked

Patch 29/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/38 Checking commit 4eec50017ab5 (linux-user, mips64: add syscall table 
generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 802 lines checked

Patch 30/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/38 Checking commit 19a0e30f46a8 (linux-user, scripts: add a script to update 
syscall.tbl)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 56 lines checked

Patch 31/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
32/38 Checking commit f41ff3c5579b (linux-user: update syscall.tbl from linux 
0bf999f9c5e7)
33/38 Checking commit d23d2a1599de (linux-user,mips: move content of 
mips_syscall_args)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#470: 
new file mode 100644

total: 0 errors, 1 warnings, 886 lines checked

Patch 33/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/38 Checking commit 1f2ea4d95fc4 (linux-user,mips: update 
syscall-args-o32.c.inc)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#908: 
new file mode 100755

total: 0 errors, 1 warnings, 938 lines checked

Patch 34/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/38 Checking commit 45ee6674ac01 (scripts: add a script to generate 
syscall_nr.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 109 lines checked

Patch 35/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/38 Checking commit 9f6200d52184 (linux-user, aarch64: sync syscall numbers 
with kernel v5.5)
37/38 Checking commit 6782f6a378da (linux-user, nios2: sync syscall numbers 
with kernel v5.5)
38/38 Checking commit 10fafb17f794 (linux-user, openrisc: sync syscall numbers 
with kernel v5.5)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
[Prev in Thread]
Current Thread
[Next in Thread]
[PULL 17/38] linux-user, m68k: add syscall table generation support, (continued)
- [PULL 17/38] linux-user, m68k: add syscall table generation support, Laurent Vivier, 2020/03/16
- [PULL 26/38] linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl, Laurent Vivier, 2020/03/16
- [PULL 34/38] linux-user,mips: update syscall-args-o32.c.inc, Laurent Vivier, 2020/03/16
- [PULL 28/38] linux-user, x86_64: add syscall table generation support, Laurent Vivier, 2020/03/16
- [PULL 24/38] linux-user, s390x: add syscall table generation support, Laurent Vivier, 2020/03/16
- [PULL 38/38] linux-user, openrisc: sync syscall numbers with kernel v5.5, Laurent Vivier, 2020/03/16
- Re: [PULL 00/38] Linux user for 5.0 patches, Peter Maydell, 2020/03/16
  - Re: [PULL 00/38] Linux user for 5.0 patches, Laurent Vivier, 2020/03/17
- Re: [PULL 00/38] Linux user for 5.0 patches, no-reply, 2020/03/16
- Re: [PULL 00/38] Linux user for 5.0 patches, no-reply, 2020/03/16
- Re: [PULL 00/38] Linux user for 5.0 patches, no-reply <=
- Re: [PULL 00/38] Linux user for 5.0 patches, no-reply, 2020/03/16
- Re: [PULL 00/38] Linux user for 5.0 patches, no-reply, 2020/03/16
Prev by Date: Re: [PATCH v2 6/8] target/ppc: allow ppc_cpu_do_system_reset to take an alternate vector
Next by Date: Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image
Previous by thread: Re: [PULL 00/38] Linux user for 5.0 patches
Next by thread: Re: [PULL 00/38] Linux user for 5.0 patches
Index(es):
- Date
- Thread