[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 25/34] qapi: New special feature flag "deprecated"
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 25/34] qapi: New special feature flag "deprecated" |
Date: |
Sun, 15 Mar 2020 17:53:01 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 3/15/20 3:46 PM, Markus Armbruster wrote:
>> Unlike regular feature flags, the new special feature flag
>> "deprecated" is recognized by the QAPI generator. For now, it's only
>> permitted with commands, events, and struct members. It will be put
>> to use shortly.
>
> What about using a '@DeprecatedSince' tag?
> Ah, that would apply to the whole structure and not a particular member...
>
> I am wondering because sometimes we deprecate something for 2 releases
> but then once the deadline passed we forgot to remove it. Having the
> release version deadline along with deprecation would help automating
> removal checks.
> Maybe we can use a tag with release version, such 'deprecated_since:5.0'?
Intended consumer for "since <version>" information?
So far, it's been just developers. Searching the QAPI schema for
deprecated stuff past its grace period hasn't been the problem;
remembering to search for it has been.
- Re: [PATCH v3 01/34] qemu-doc: Belatedly document QMP command arg & result deprecation, (continued)
- [PATCH v3 17/34] qapi/schema: Reorder classes so related ones are together, Markus Armbruster, 2020/03/15
- [PATCH v3 19/34] qapi/schema: Call QAPIDoc.connect_member() in just one place, Markus Armbruster, 2020/03/15
- [PATCH v3 22/34] qapi: Simplify how qmp_dispatch() deals with QCO_NO_SUCCESS_RESP, Markus Armbruster, 2020/03/15
- [PATCH v3 25/34] qapi: New special feature flag "deprecated", Markus Armbruster, 2020/03/15
- [PATCH v3 13/34] qapi: Consistently put @features parameter right after @ifcond, Markus Armbruster, 2020/03/15
- [PATCH v3 12/34] qapi: Add feature flags to remaining definitions, Markus Armbruster, 2020/03/15
- [PATCH v3 28/34] qapi: Implement deprecated-output=hide for QMP command results, Markus Armbruster, 2020/03/15