[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/34] qemu-doc: Belatedly document QMP command arg & resu
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 01/34] qemu-doc: Belatedly document QMP command arg & result deprecation |
Date: |
Mon, 16 Mar 2020 19:34:37 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 3/15/20 9:46 AM, Markus Armbruster wrote:
>> A number of deprecated QMP arguments and results were missed in commit
>> eb22aeca65 "docs: document deprecation policy & deprecated features in
>> appendix" (v2.10.0):
>>
>
>>
>> Since then, we missed a few more:
>>
>> * Commit 3c605f4074 "commit: Add top-node/base-node options" (v3.1.0)
>> deprecated block-commit arguments @base and @top.
>>
>> * Commit 4db6ceb0b5 "block/dirty-bitmap: add recording and busy
>> properties" (v4.0.0) deprecated query-named-block-nodes result
>> @dirty-bitmaps member @status, not just query-block.
>>
>> Make up for all that.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> docs/system/deprecated.rst | 48 ++++++++++++++++++++++++++++++++++----
>> 1 file changed, 44 insertions(+), 4 deletions(-)
>
> Should we remove any of these features that have been deprecated long
> enough? But that can be separate, having this patch just add mention
> that was previously forgotten is fine.
Up to the subsystem maintainers, I'd say.
I think we should sweep deprecated.rst on every release. Early in the
development cycle seems best.
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- Re: [PATCH v3 04/34] docs/devel/qapi-code-gen: Document 'features' introspection, (continued)
- [PATCH v3 30/34] qapi: Implement deprecated-output=hide for QMP event data, Markus Armbruster, 2020/03/15
- [PATCH v3 33/34] qapi: Implement deprecated-input=reject for QMP command arguments, Markus Armbruster, 2020/03/15
- [PATCH v3 07/34] tests/test-qmp-cmds: Simplify test data setup, Markus Armbruster, 2020/03/15
- [PATCH v3 11/34] qapi/schema: Clean up around QAPISchemaEntity.connect_doc(), Markus Armbruster, 2020/03/15
- [PATCH v3 01/34] qemu-doc: Belatedly document QMP command arg & result deprecation, Markus Armbruster, 2020/03/15
- [PATCH v3 17/34] qapi/schema: Reorder classes so related ones are together, Markus Armbruster, 2020/03/15
- [PATCH v3 19/34] qapi/schema: Call QAPIDoc.connect_member() in just one place, Markus Armbruster, 2020/03/15
- [PATCH v3 22/34] qapi: Simplify how qmp_dispatch() deals with QCO_NO_SUCCESS_RESP, Markus Armbruster, 2020/03/15
- [PATCH v3 25/34] qapi: New special feature flag "deprecated", Markus Armbruster, 2020/03/15