qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 6/9] block/block-copy: refactor interfaces to use bytes in


From: Max Reitz
Subject: Re: [PATCH v3 6/9] block/block-copy: refactor interfaces to use bytes instead of end
Date: Tue, 10 Mar 2020 15:44:03 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 06.03.20 08:38, Vladimir Sementsov-Ogievskiy wrote:
> We have a lot of "chunk_end - start" invocations, let's switch to
> bytes/cur_bytes scheme instead.
> 
> While being here, improve check on block_copy_do_copy parameters to not
> overflow when calculating nbytes and use int64_t for bytes in
> block_copy for consistency.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Reviewed-by: Andrey Shinkevich <address@hidden>
> ---
>  include/block/block-copy.h |  6 +--
>  block/block-copy.c         | 78 ++++++++++++++++++++------------------
>  2 files changed, 44 insertions(+), 40 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]