Re: [PATCH v30 00/22] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
01f0378 qemu-doc.texi: Add RX section.
756b686 BootLinuxConsoleTest: Test the RX-Virt machine
837ab5e Add rx-softmmu
a54c4a7 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
8f05d87 hw/rx: Honor -accel qtest
17b5d48 hw/rx: RX Target hardware definition
15aaf04 hw/char: RX62N serial communication interface (SCI)
863466a hw/timer: RX62N internal timer modules
8e2ddf8 hw/intc: RX62N interrupt controller (ICUa)
c2b722c target/rx: Dump bytes for each insn during disassembly
abe5c93 target/rx: Collect all bytes during disassembly
2856668 target/rx: Emit all disassembly in one prt()
fbb8022 target/rx: Use prt_ldmi for XCHG_mr disassembly
e02a968 target/rx: Replace operand with prt_ldmi in disassembler
ebe47d5 target/rx: Disassemble rx_index_addr into a string
2123e83 target/rx: RX disassembler
62b81b7 target/rx: CPU definition
d4da3eb target/rx: TCG helper
c6645faa target/rx: TCG translation
97f0ecf hw/registerfields.h: Add 8bit and 16bit register macros
4d682d8 qemu/bitops.h: Add extract8 and extract16
6e4e0c1 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 6e4e0c17243b (MAINTAINERS: Add RX)
2/22 Checking commit 4d682d871146 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 97f0ecffe465 (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit c6645faa5ab8 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit d4da3eb54e32 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 62b81b7701c5 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 2123e834292a (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit ebe47d55bde6 (target/rx: Disassemble rx_index_addr into a 
string)
9/22 Checking commit e02a9686860e (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/22 Checking commit fbb8022a3edc (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/22 Checking commit 2856668a7c4a (target/rx: Emit all disassembly in one 
prt())
12/22 Checking commit abe5c9380941 (target/rx: Collect all bytes during 
disassembly)
13/22 Checking commit c2b722c81fe2 (target/rx: Dump bytes for each insn during 
disassembly)
14/22 Checking commit 8e2ddf8e72aa (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 863466adfcc5 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 15aaf048e883 (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 17b5d48e9ee0 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit 8f05d879200d (hw/rx: Honor -accel qtest)
19/22 Checking commit a54c4a7c0cde (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/22 Checking commit 837ab5e2281d (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 756b686baccc (BootLinuxConsoleTest: Test the RX-Virt 
machine)
22/22 Checking commit 01f0378fbddb (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden