[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/8] multifd: Add multifd-method parameter
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 1/8] multifd: Add multifd-method parameter |
Date: |
Thu, 30 Jan 2020 13:17:53 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Juan Quintela <address@hidden> writes:
> Markus Armbruster <address@hidden> wrote:
>> Juan Quintela <address@hidden> writes:
>>
>>> This will store the compression method to use. We start with none.
>>>
>>> Signed-off-by: Juan Quintela <address@hidden>
>>> Reviewed-by: Markus Armbruster <address@hidden>
>>
>> I don't remember giving my R-by. I gave my Acked-by for
>> [PATCH v2 06/10] migration: Add multifd-compress parameter
>> Message-ID: <address@hidden>
>> https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg04153.html
>
>> If I did give my R-by for a later revision, let me know.
>
> Hi
>
> Ouch, I *thought* that you got confused. It happens to me all the time.
> Apologies.
> So, how I should I put that Acked-by: in the commit?
Replace
Reviewed-by: Markus Armbruster <address@hidden>
by
Acked-by: Markus Armbruster <address@hidden>
>> One small suggestion below.
>
> Thanks.
>
>>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>> [...]
>>> diff --git a/qapi/migration.json b/qapi/migration.json
>>> index b7348d0c8b..96a126751c 100644
>>> --- a/qapi/migration.json
>>> +++ b/qapi/migration.json
>>> @@ -488,6 +488,19 @@
>>> ##
>>> { 'command': 'query-migrate-capabilities', 'returns':
>>> ['MigrationCapabilityStatus']}
>>>
>>> +##
>>> +# @MultiFDMethod:
>>> +#
>>> +# An enumeration of multifd compression.
>>
>> Suggest "compression methods."
>
> will do.
>
> Sorry again for the missunderstanding.
No harm, no foul :)
- [PATCH v5 0/8] Multifd Migration Compression, Juan Quintela, 2020/01/29
- [PATCH v5 3/8] multifd: Make no compression operations into its own structure, Juan Quintela, 2020/01/29
- [PATCH v5 4/8] multifd: Add multifd-zlib-level parameter, Juan Quintela, 2020/01/29
- [PATCH v5 6/8] configure: Enable test and libs for zstd, Juan Quintela, 2020/01/29
- [PATCH v5 5/8] multifd: Add zlib compression multifd support, Juan Quintela, 2020/01/29
- [PATCH v5 7/8] multifd: Add multifd-zstd-level parameter, Juan Quintela, 2020/01/29
- [PATCH v5 8/8] multifd: Add zstd compression multifd support, Juan Quintela, 2020/01/29