[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/8] multifd: Add multifd-method parameter
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 1/8] multifd: Add multifd-method parameter |
Date: |
Thu, 30 Jan 2020 08:54:09 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Juan Quintela <address@hidden> writes:
> This will store the compression method to use. We start with none.
>
> Signed-off-by: Juan Quintela <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
I don't remember giving my R-by. I gave my Acked-by for
[PATCH v2 06/10] migration: Add multifd-compress parameter
Message-ID: <address@hidden>
https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg04153.html
If I did give my R-by for a later revision, let me know.
One small suggestion below.
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
[...]
> diff --git a/qapi/migration.json b/qapi/migration.json
> index b7348d0c8b..96a126751c 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -488,6 +488,19 @@
> ##
> { 'command': 'query-migrate-capabilities', 'returns':
> ['MigrationCapabilityStatus']}
>
> +##
> +# @MultiFDMethod:
> +#
> +# An enumeration of multifd compression.
Suggest "compression methods."
> +#
> +# @none: no compression.
> +#
> +# Since: 5.0
> +#
> +##
> +{ 'enum': 'MultiFDMethod',
> + 'data': [ 'none' ] }
> +
> ##
> # @MigrationParameter:
> #
> @@ -586,6 +599,9 @@
> # @max-cpu-throttle: maximum cpu throttle percentage.
> # Defaults to 99. (Since 3.1)
> #
> +# @multifd-method: Which compression method to use.
> +# Defaults to none. (Since 5.0)
> +#
> # Since: 2.4
> ##
> { 'enum': 'MigrationParameter',
> @@ -598,7 +614,7 @@
> 'downtime-limit', 'x-checkpoint-delay', 'block-incremental',
> 'multifd-channels',
> 'xbzrle-cache-size', 'max-postcopy-bandwidth',
> - 'max-cpu-throttle' ] }
> + 'max-cpu-throttle', 'multifd-method' ] }
>
> ##
> # @MigrateSetParameters:
> @@ -688,6 +704,9 @@
> # @max-cpu-throttle: maximum cpu throttle percentage.
> # The default value is 99. (Since 3.1)
> #
> +# @multifd-method: Which compression method to use.
> +# Defaults to none. (Since 5.0)
> +#
> # Since: 2.4
> ##
> # TODO either fuse back into MigrationParameters, or make
> @@ -713,7 +732,8 @@
> '*multifd-channels': 'int',
> '*xbzrle-cache-size': 'size',
> '*max-postcopy-bandwidth': 'size',
> - '*max-cpu-throttle': 'int' } }
> + '*max-cpu-throttle': 'int',
> + '*multifd-method': 'MultiFDMethod' } }
>
> ##
> # @migrate-set-parameters:
> @@ -823,6 +843,9 @@
> # Defaults to 99.
> # (Since 3.1)
> #
> +# @multifd-method: Which compression method to use.
> +# Defaults to none. (Since 5.0)
> +#
> # Since: 2.4
> ##
> { 'struct': 'MigrationParameters',
> @@ -846,7 +869,8 @@
> '*multifd-channels': 'uint8',
> '*xbzrle-cache-size': 'size',
> '*max-postcopy-bandwidth': 'size',
> - '*max-cpu-throttle':'uint8'} }
> + '*max-cpu-throttle': 'uint8',
> + '*multifd-method': 'MultiFDMethod' } }
>
> ##
> # @query-migrate-parameters:
[...]
- [PATCH v5 0/8] Multifd Migration Compression, Juan Quintela, 2020/01/29
- [PATCH v5 3/8] multifd: Make no compression operations into its own structure, Juan Quintela, 2020/01/29
- [PATCH v5 4/8] multifd: Add multifd-zlib-level parameter, Juan Quintela, 2020/01/29
- [PATCH v5 6/8] configure: Enable test and libs for zstd, Juan Quintela, 2020/01/29
- [PATCH v5 5/8] multifd: Add zlib compression multifd support, Juan Quintela, 2020/01/29
- [PATCH v5 7/8] multifd: Add multifd-zstd-level parameter, Juan Quintela, 2020/01/29