[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 12/13] add 'error' prefix to vreport

From: Markus Armbruster
Subject: Re: [PATCH v3 12/13] add 'error' prefix to vreport
Date: Wed, 29 Jan 2020 11:38:04 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Maxim Levitsky <address@hidden> writes:

> On Mon, 2020-01-27 at 12:36 +0200, Maxim Levitsky wrote:
>> This changes most of qemu's error messages,
>> but it feels like the right thing to do.
>> This is WIP patch, since I updated most of iotests but not all of them,
>> and will be updated if this patch is accepeted in the review.
>> Also few error message already have 'error' prefix, which should be removed.
>> Signed-off-by: Maxim Levitsky <address@hidden>
>> Suggested-by: Markus Armbruster <address@hidden>
> Since Peter Krempa pointed out that libvirt doesn't need the error prefixes 
> any more
> (this wasn't the case when I developed this sadly) I guess I'll drop that 
> patch,
> although to me it looks just better to have errors cleanly prefixed to be 
> honest.

The "libvirt needs this" justification is gone.  But perhaps we want it
anyway.  It's hardly an "HMP monitor handlers cleanups", though.
Suggest to split it off this series, so it can't hold it back.  Posting
it separately should also give it a better chance to be noticed.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]