[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

From: Ján Tomko
Subject: Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups
Date: Tue, 28 Jan 2020 10:13:32 +0100

On Mon, Jan 27, 2020 at 04:01:31PM -0500, John Snow wrote:

On 1/27/20 3:43 PM, Peter Krempa wrote:
On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote:

On 1/27/20 5:36 AM, Maxim Levitsky wrote:
This patch series is bunch of cleanups
to the hmp monitor code.

This series only touched blockdev related hmp handlers.

No functional changes expected other that
light error message changes by the last patch.

This was inspired by this bugzilla:

Basically some users still parse hmp error messages,
and they would like to have them prefixed with 'Error:'


The bug was reported at the time when libvirt didn't use blockdev yet,
but at this point it's pointless from our side.

Just for the record, this bug was the motivation for the prefix request:

This wouldn't even fix
the scenario when old (pre-5.10) libvirt would use new qemu because the
drive-add handler never checked the error prefix.

And running older libvirt with newer QEMU is not something we care



Thank you for the report from libvirtville :)


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]