Re: [PATCH 6/8] tests/vm: add --boot-console switch

[Robert Foley]

On Mon, 27 Jan 2020 at 07:56, Alex Bennée <address@hidden> wrote:
> > @@ -523,6 +525,10 @@ def main(vmcls, config=None):
> >          if args.snapshot:
> >              img += ",snapshot=on"
> >          vm.boot(img)
> > +        wait_boot = getattr(vm, "wait_boot", None)
>
> Didn't we add a __getattr method, so we can do self._config['wait_boot']
>
> > +        if args.boot_console and callable(wait_boot):
> > +            vm.console_init()
> > +            wait_boot()
>
> isn't wait_boot always callable because it's part of the basevm?

My bad.  Missed changing this after moving the method into the base class.
Yes, we should change it to something simpler like:
if args.boot_console:
            vm.console_init()
            self.wait_boot()

Thanks & Regards,
-Rob
>
> >          vm.wait_ssh()
> >      except Exception as e:
> >          if isinstance(e, SystemExit) and e.code == 0:
>
>
> --
> Alex Bennée