[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/12] linux-user: Add support for KCOV_<ENABLE|DISABLE> ioct
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 11/12] linux-user: Add support for KCOV_<ENABLE|DISABLE> ioctls |
Date: |
Wed, 22 Jan 2020 15:16:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 |
Le 16/01/2020 à 23:49, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic <address@hidden>
>
> KCOV_ENABLE and KCOV_DISABLE play the role in kernel coverage
> tracing. These ioctls do not use the third argument of ioctl()
> system call and are straightforward to implement in QEMU.
>
> Reviewed-by: Laurent Vivier <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> linux-user/ioctls.h | 5 +++++
> linux-user/syscall.c | 3 +++
> linux-user/syscall_defs.h | 4 ++++
> 3 files changed, 12 insertions(+)
>
> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> index d72cd76..39b3825 100644
> --- a/linux-user/ioctls.h
> +++ b/linux-user/ioctls.h
> @@ -552,3 +552,8 @@
> IOCTL_IGNORE(TIOCSTART)
> IOCTL_IGNORE(TIOCSTOP)
> #endif
> +
> +#ifdef CONFIG_KCOV
> + IOCTL(KCOV_ENABLE, 0, TYPE_NULL)
> + IOCTL(KCOV_DISABLE, 0, TYPE_NULL)
> +#endif
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 171c0ca..6edcb0d 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -73,6 +73,9 @@
> #ifdef CONFIG_SENDFILE
> #include <sys/sendfile.h>
> #endif
> +#ifdef CONFIG_KCOV
> +#include <sys/kcov.h>
> +#endif
>
> #define termios host_termios
> #define winsize host_winsize
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index 46dc565..c8999ef 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -2461,6 +2461,10 @@ struct target_mtpos {
> #define TARGET_MTIOCGET TARGET_IOR('m', 2, struct target_mtget)
> #define TARGET_MTIOCPOS TARGET_IOR('m', 3, struct target_mtpos)
>
> +/* kcov ioctls */
> +#define TARGET_KCOV_ENABLE TARGET_IO('c', 100)
> +#define TARGET_KCOV_DISABLE TARGET_IO('c', 101)
> +
> struct target_sysinfo {
> abi_long uptime; /* Seconds since boot */
> abi_ulong loads[3]; /* 1, 5, and 15 minute load averages */
>
Applied to my linux-user branch.
Thanks,
Laurent
- [PATCH 00/12] linux-user: Add support for fs, fd,and kcov ioctls, Aleksandar Markovic, 2020/01/16
- [PATCH 02/12] linux-user: Add support for FS_IOC32_<GET|SET>FLAGS ioctls, Aleksandar Markovic, 2020/01/16
- [PATCH 03/12] linux-user: Add support for FS_IOC32_<GET|SET>VERSION ioctls, Aleksandar Markovic, 2020/01/16
- [PATCH 12/12] linux-user: Add support for KCOV_INIT_TRACE ioctl, Aleksandar Markovic, 2020/01/16
- [PATCH 09/12] linux-user: Add support for FDGETFDCSTAT ioctl, Aleksandar Markovic, 2020/01/16
- [PATCH 05/12] linux-user: Add support for FITRIM ioctl, Aleksandar Markovic, 2020/01/16
- [PATCH 11/12] linux-user: Add support for KCOV_<ENABLE|DISABLE> ioctls, Aleksandar Markovic, 2020/01/16
- Re: [PATCH 11/12] linux-user: Add support for KCOV_<ENABLE|DISABLE> ioctls,
Laurent Vivier <=
- [PATCH 10/12] configure: Detect kcov support and introduce CONFIG_KCOV, Aleksandar Markovic, 2020/01/16
- [PATCH 01/12] linux-user: Add support for FS_IOC_<GET|SET>VERSION ioctls, Aleksandar Markovic, 2020/01/16
- [PATCH 08/12] linux-user: Add support for FDFMT<BEG|TRK|END> ioctls, Aleksandar Markovic, 2020/01/16
- [PATCH 06/12] linux-user: Add support for FIFREEZE and FITHAW ioctls, Aleksandar Markovic, 2020/01/16
- [PATCH 07/12] linux-user: Add support for FD<SETEMSGTRESH|SETMAXERRS|GETMAXERRS> ioctls, Aleksandar Markovic, 2020/01/16