[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] linux-user: Add support for FS_IOC32_<GET|SET>FLAGS io
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 02/12] linux-user: Add support for FS_IOC32_<GET|SET>FLAGS ioctls |
Date: |
Wed, 22 Jan 2020 15:06:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 |
Le 16/01/2020 à 23:49, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic <address@hidden>
>
> These FS_IOC32_<GET|SET>FLAGS ioctls are identical to
> FS_IOC_<GET|SET>FLAGS ioctls, but without the anomaly of their
> number defined as if their third argument is of type long, while
> it is treated internally in kernel as is of type int.
>
> Reviewed-by: Laurent Vivier <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> linux-user/ioctls.h | 2 ++
> linux-user/syscall_defs.h | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> index c44f42e..4fd6939 100644
> --- a/linux-user/ioctls.h
> +++ b/linux-user/ioctls.h
> @@ -140,6 +140,8 @@
> IOCTL(FS_IOC_SETFLAGS, IOC_W, MK_PTR(TYPE_INT))
> IOCTL(FS_IOC_GETVERSION, IOC_R, MK_PTR(TYPE_INT))
> IOCTL(FS_IOC_SETVERSION, IOC_W, MK_PTR(TYPE_INT))
> + IOCTL(FS_IOC32_GETFLAGS, IOC_R, MK_PTR(TYPE_INT))
> + IOCTL(FS_IOC32_SETFLAGS, IOC_W, MK_PTR(TYPE_INT))
>
> #ifdef CONFIG_USBFS
> /* USB ioctls */
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index f68a8b6..964b2b4 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -920,6 +920,8 @@ struct target_pollfd {
> #define TARGET_FS_IOC_GETVERSION TARGET_IOR('v', 1, abi_long)
> #define TARGET_FS_IOC_SETVERSION TARGET_IOW('v', 2, abi_long)
> #define TARGET_FS_IOC_FIEMAP TARGET_IOWR('f',11,struct fiemap)
> +#define TARGET_FS_IOC32_GETFLAGS TARGET_IOR('f', 1, int)
> +#define TARGET_FS_IOC32_SETFLAGS TARGET_IOW('f', 2, int)
>
> /* usb ioctls */
> #define TARGET_USBDEVFS_CONTROL TARGET_IOWRU('U', 0)
>
Applied to my linux-user branch.
Thanks,
Laurent
- [PATCH 00/12] linux-user: Add support for fs, fd,and kcov ioctls, Aleksandar Markovic, 2020/01/16
- [PATCH 02/12] linux-user: Add support for FS_IOC32_<GET|SET>FLAGS ioctls, Aleksandar Markovic, 2020/01/16
- Re: [PATCH 02/12] linux-user: Add support for FS_IOC32_<GET|SET>FLAGS ioctls,
Laurent Vivier <=
- [PATCH 03/12] linux-user: Add support for FS_IOC32_<GET|SET>VERSION ioctls, Aleksandar Markovic, 2020/01/16
- [PATCH 12/12] linux-user: Add support for KCOV_INIT_TRACE ioctl, Aleksandar Markovic, 2020/01/16
- [PATCH 09/12] linux-user: Add support for FDGETFDCSTAT ioctl, Aleksandar Markovic, 2020/01/16
- [PATCH 05/12] linux-user: Add support for FITRIM ioctl, Aleksandar Markovic, 2020/01/16
- [PATCH 11/12] linux-user: Add support for KCOV_<ENABLE|DISABLE> ioctls, Aleksandar Markovic, 2020/01/16
- [PATCH 10/12] configure: Detect kcov support and introduce CONFIG_KCOV, Aleksandar Markovic, 2020/01/16