[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/6] Fix more GCC9 -O3 warnings

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
Date: Mon, 20 Jan 2020 20:02:09 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

Hi Paolo,

On 1/18/20 8:24 PM, Paolo Bonzini wrote:
On 18/12/19 07:05, Markus Armbruster wrote:
"Chubb, Peter (Data61, Kensington NSW)" <address@hidden>

"Philippe" == Philippe Mathieu-Daudé <address@hidden> writes:

Philippe> Fix some trivial warnings when building with -O3.

For compatibility with lint and other older checkers, it'd be good to keep
this as /* FALLTHROUGH */ (which gcc should accept according to its

We have hundreds of /* fall through */ comments already.

Fixing the comments' placement is a different matter, and should be
done.  Seems to me that until gcc started warning for this, noone had
actually run a checker, and the comments were just for human info.

Peter C

Queued, thanks.

Thanks, but I sent a v2 (address@hidden) with:

- addressed Thomas and Aleksandar comments
- dropped 'hw/scsi/megasas: Silent GCC9 duplicated-cond warning'
- dropped 'qemu-io-cmds: Silent GCC9 format-overflow warning'


Can you queue it instead?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]