Re: [PATCH v5 4/6] hppa: add emulation of LASI PS2 controllers

[Sven Schnelle]

On Fri, Jan 03, 2020 at 07:15:49AM +0100, Philippe Mathieu-Daudé wrote:
> On 12/20/19 10:15 PM, Sven Schnelle wrote:
> > Signed-off-by: Sven Schnelle <address@hidden>
> > ---
> >   hw/hppa/Kconfig            |   1 +
> >   hw/hppa/lasi.c             |  10 +-
> >   hw/input/Kconfig           |   3 +
> >   hw/input/Makefile.objs     |   1 +
> >   hw/input/lasips2.c         | 289 +++++++++++++++++++++++++++++++++++++
> >   hw/input/ps2.c             |   5 +
> >   hw/input/trace-events      |   5 +
> >   include/hw/input/lasips2.h |  16 ++
> >   include/hw/input/ps2.h     |   1 +
> >   9 files changed, 330 insertions(+), 1 deletion(-)
> >   create mode 100644 hw/input/lasips2.c
> >   create mode 100644 include/hw/input/lasips2.h
> > 
> > diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig
> > index 2a7b38d6d6..7f9be7f25c 100644
> > --- a/hw/hppa/Kconfig
> > +++ b/hw/hppa/Kconfig
> > @@ -11,3 +11,4 @@ config DINO
> >       select MC146818RTC
> >       select LSI_SCSI_PCI
> >       select LASI_82596
> > +    select LASIPS2
> 
> If these components are part of the LASI chipset, you don't need an specific
> Kconfig entry for each, you can simply use the LASI one.
> 
> Add a LASI entry in hw/hppa/Kconfig such:
> 
> config LASI
>     bool
>     select I82596_COMMON
>     select PS2
> 

I'll send a patch as soon as this series is merged - that's easier than
resending the whole series.

Regards
Sven