[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 09/29] plugins: Include trace/mem.h in api.c

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 09/29] plugins: Include trace/mem.h in api.c
Date: Fri, 3 Jan 2020 07:22:48 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

Hi Richard,

On 12/29/19 12:11 AM, Richard Henderson wrote:
Code movement in an upcoming patch will show that this file
was implicitly depending on trace/mem.h being included beforehand.

Ah, it uses the TRACE_MEM_* macros from "trace/mem-internal.h", which is include by "trace/mem.h". OK.

Which part requires "trace-root.h"? Isn't it "trace/mem-internal.h" that should include "trace-root.h"?

Reported-by: Alex Bennée <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
  plugins/api.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/plugins/api.c b/plugins/api.c
index fa1d9f276d..cb7098ce79 100644
--- a/plugins/api.c
+++ b/plugins/api.c
@@ -46,6 +46,8 @@
  #include "qemu/plugin-memory.h"
  #include "hw/boards.h"
+#include "trace-root.h"
+#include "trace/mem.h"
/* Uninstall and Reset handlers */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]