RE: [PATCH RFC 01/12] migration: Add multiRDMA capability support

[fengzhimin]

Thanks for your review. I will fix these errors in the next version(V2).
I hope you can busy schedule to find time to check other patches about 
Multi-RDMA.

-----Original Message-----
From: Eric Blake [mailto:address@hidden] 
Sent: Tuesday, January 14, 2020 12:27 AM
To: fengzhimin <address@hidden>; address@hidden; address@hidden; address@hidden
Cc: address@hidden; Zhanghailiang <address@hidden>; address@hidden
Subject: Re: [PATCH RFC 01/12] migration: Add multiRDMA capability support

On 1/8/20 10:59 PM, Zhimin Feng wrote:
> From: fengzhimin <address@hidden>
> 
> Signed-off-by: fengzhimin <address@hidden>
> ---

> +++ b/qapi/migration.json
> @@ -421,6 +421,8 @@
>   # @validate-uuid: Send the UUID of the source to allow the destination
>   #                 to ensure it is the same. (since 4.2)
>   #
> +# @multirdma: Use more than one channels for rdma migration. (since 4.2)

We've missed 4.2; the next release will be 5.0.

> +#
>   # Since: 1.2
>   ##
>   { 'enum': 'MigrationCapability',
> @@ -428,7 +430,7 @@
>              'compress', 'events', 'postcopy-ram', 'x-colo', 'release-ram',
>              'block', 'return-path', 'pause-before-switchover', 'multifd',
>              'dirty-bitmaps', 'postcopy-blocktime', 'late-block-activate',
> -           'x-ignore-shared', 'validate-uuid' ] }
> +           'x-ignore-shared', 'validate-uuid', 'multirdma' ] }
>   
>   ##
>   # @MigrationCapabilityStatus:
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org