[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 30/30] multifd: Allocate uint64_t instead of ram_addr_t
From: |
Daniel P . Berrangé |
Subject: |
Re: [PULL 30/30] multifd: Allocate uint64_t instead of ram_addr_t |
Date: |
Tue, 14 Jan 2020 12:02:34 +0000 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Tue, Jan 14, 2020 at 12:39:26PM +0100, Juan Quintela wrote:
> We receive that value over the network, and ram_addr_t depends of
> architecture. Just make enough space for 64bit.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> migration/ram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index d0940387d1..ba6e0eea15 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -1267,7 +1267,7 @@ int multifd_save_setup(void)
> p->id = i;
> p->pages = multifd_pages_init(page_count);
> p->packet_len = sizeof(MultiFDPacket_t)
> - + sizeof(ram_addr_t) * page_count;
> + + sizeof(uint64_t) * page_count;
> p->packet = g_malloc0(p->packet_len);
> p->packet->magic = cpu_to_be32(MULTIFD_MAGIC);
> p->packet->version = cpu_to_be32(MULTIFD_VERSION);
Reviewed-by: Daniel P. Berrangé <address@hidden>
but I think this ought to be patch 2 in the series, otherwise the
multifd test case that's introduced at the start of this series
will likely fail when doing git bisect.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PULL 21/30] migration/multifd: clean pages after filling packet, (continued)
- [PULL 21/30] migration/multifd: clean pages after filling packet, Juan Quintela, 2020/01/14
- [PULL 22/30] migration/multifd: not use multifd during postcopy, Juan Quintela, 2020/01/14
- [PULL 23/30] migration/multifd: fix nullptr access in terminating multifd threads, Juan Quintela, 2020/01/14
- [PULL 24/30] migration/multifd: fix destroyed mutex access in terminating multifd threads, Juan Quintela, 2020/01/14
- [PULL 25/30] Bug #1829242 correction., Juan Quintela, 2020/01/14
- [PULL 26/30] migration: Define VMSTATE_INSTANCE_ID_ANY, Juan Quintela, 2020/01/14
- [PULL 27/30] migration: Change SaveStateEntry.instance_id into uint32_t, Juan Quintela, 2020/01/14
- [PULL 28/30] apic: Use 32bit APIC ID for migration instance ID, Juan Quintela, 2020/01/14
- [PULL 29/30] migration: Support QLIST migration, Juan Quintela, 2020/01/14
- [PULL 30/30] multifd: Allocate uint64_t instead of ram_addr_t, Juan Quintela, 2020/01/14
- Re: [PULL 30/30] multifd: Allocate uint64_t instead of ram_addr_t,
Daniel P . Berrangé <=
- Re: [PULL 00/30] Migration pull patches (3rd try), Juan Quintela, 2020/01/14