[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 22/30] migration/multifd: not use multifd during postcopy
From: |
Juan Quintela |
Subject: |
[PULL 22/30] migration/multifd: not use multifd during postcopy |
Date: |
Tue, 14 Jan 2020 12:39:18 +0100 |
From: Wei Yang <address@hidden>
We don't support multifd during postcopy, but user still could enable
both multifd and postcopy. This leads to migration failure.
Skip multifd during postcopy.
Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
migration/ram.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index a05448c0c9..d4f33a4f2f 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2587,10 +2587,13 @@ static int ram_save_target_page(RAMState *rs,
PageSearchStatus *pss,
}
/*
- * do not use multifd for compression as the first page in the new
- * block should be posted out before sending the compressed page
+ * Do not use multifd for:
+ * 1. Compression as the first page in the new block should be posted out
+ * before sending the compressed page
+ * 2. In postcopy as one whole host page should be placed
*/
- if (!save_page_use_compression(rs) && migrate_use_multifd()) {
+ if (!save_page_use_compression(rs) && migrate_use_multifd()
+ && !migration_in_postcopy()) {
return ram_save_multifd_page(rs, block, offset);
}
--
2.24.1
- [PULL 12/30] migration: add savevm_state_handler_remove(), (continued)
- [PULL 12/30] migration: add savevm_state_handler_remove(), Juan Quintela, 2020/01/14
- [PULL 13/30] migration: savevm_state_handler_insert: constant-time element insertion, Juan Quintela, 2020/01/14
- [PULL 14/30] migration/ram: Yield periodically to the main loop, Juan Quintela, 2020/01/14
- [PULL 15/30] migration/postcopy: reduce memset when it is zero page and matches_target_page_size, Juan Quintela, 2020/01/14
- [PULL 16/30] migration/postcopy: wait for decompress thread in precopy, Juan Quintela, 2020/01/14
- [PULL 17/30] migration/postcopy: count target page number to decide the place_needed, Juan Quintela, 2020/01/14
- [PULL 18/30] migration/postcopy: set all_zero to true on the first target page, Juan Quintela, 2020/01/14
- [PULL 19/30] migration/postcopy: enable random order target page arrival, Juan Quintela, 2020/01/14
- [PULL 20/30] migration/postcopy: enable compress during postcopy, Juan Quintela, 2020/01/14
- [PULL 21/30] migration/multifd: clean pages after filling packet, Juan Quintela, 2020/01/14
- [PULL 22/30] migration/multifd: not use multifd during postcopy,
Juan Quintela <=
- [PULL 23/30] migration/multifd: fix nullptr access in terminating multifd threads, Juan Quintela, 2020/01/14
- [PULL 24/30] migration/multifd: fix destroyed mutex access in terminating multifd threads, Juan Quintela, 2020/01/14
- [PULL 25/30] Bug #1829242 correction., Juan Quintela, 2020/01/14
- [PULL 26/30] migration: Define VMSTATE_INSTANCE_ID_ANY, Juan Quintela, 2020/01/14
- [PULL 27/30] migration: Change SaveStateEntry.instance_id into uint32_t, Juan Quintela, 2020/01/14
- [PULL 28/30] apic: Use 32bit APIC ID for migration instance ID, Juan Quintela, 2020/01/14
- [PULL 29/30] migration: Support QLIST migration, Juan Quintela, 2020/01/14
- [PULL 30/30] multifd: Allocate uint64_t instead of ram_addr_t, Juan Quintela, 2020/01/14
- Re: [PULL 00/30] Migration pull patches (3rd try), Juan Quintela, 2020/01/14