Re: [for-5.0 PATCH 03/11] migration: introduce icount field for snapshots

[Alex Bennée]

Kevin Wolf <address@hidden> writes:

> Am 23.12.2019 um 10:47 hat Pavel Dovgalyuk geschrieben:
>> From: Pavel Dovgalyuk <address@hidden>
>> 
>> Saving icount as a parameters of the snapshot allows navigation between
>> them in the execution replay scenario.
>> This information can be used for finding a specific snapshot for proceeding
>> the recorded execution to the specific moment of the time.
>> E.g., 'reverse step' action (introduced in one of the following patches)
>> needs to load the nearest snapshot which is prior to the current moment
>> of time.
>> 
>> Signed-off-by: Pavel Dovgalyuk <address@hidden>
>> Acked-by: Markus Armbruster <address@hidden>
>
> Acked-by: Kevin Wolf <address@hidden>

Apologies my mailer ignored my replay-all: 

This commit breaks when of the iotests for me:

 git bisect run /bin/sh -c "cd builds/all && make -j4 \
     && cd tests/qemu-iotests && ./check -qcow2 267"
 

Gives:

  make[1]: Entering directory '/home/alex.bennee/lsrc/qemu.git/slirp'
  make[1]: Nothing to be done for 'all'.
  make[1]: Leaving directory '/home/alex.bennee/lsrc/qemu.git/slirp'
  QEMU          -- 
"/home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64"
 -nodefaults -display none -accel qtest
  QEMU_IMG      -- 
"/home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/../../qemu-img"
  QEMU_IO       -- 
"/home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/../../qemu-io"  
--cache writeback -f qcow2
  QEMU_NBD      -- 
"/home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/../../qemu-nbd"
  IMGFMT        -- qcow2 (compat=1.1)
  IMGPROTO      -- file
  PLATFORM      -- Linux/x86_64 hackbox2 4.15.0-66-generic
  TEST_DIR      -- 
/home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/scratch
  SOCK_DIR      -- /tmp/tmp.NV0n5HqCUs
  SOCKET_SCM_HELPER -- 
/home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/socket_scm_helper

  267      fail       [12:17:36] [12:17:38]      (last: 1s)    output mismatch 
(see 267.out.bad)
  --- /home/alex.bennee/lsrc/qemu.git/tests/qemu-iotests/267.out  2019-10-31 
10:46:30.559805129 +0000
  +++ /home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/267.out.bad 
  2020-01-13 12:17:38.096181947 +0000
  @@ -33,7 +33,7 @@
   (qemu) savevm snap0
   (qemu) info snapshots
   List of snapshots present on all disks:
  -ID        TAG                 VM SIZE                DATE       VM CLOCK
  +ID        TAG               VM SIZE                DATE     VM CLOCK     
ICOUNT
   --        snap0                  SIZE yyyy-mm-dd hh:mm:ss   00:00:00.000
   (qemu) loadvm snap0
   (qemu) quit
  @@ -44,7 +44,7 @@
   (qemu) savevm snap0
   (qemu) info snapshots
   List of snapshots present on all disks:
  -ID        TAG                 VM SIZE                DATE       VM CLOCK
  +ID        TAG               VM SIZE                DATE     VM CLOCK     
ICOUNT

But I've also seen:

  ERROR:/home/.../qemu.git/replay/replay-events.c:80:replay_flush_events:
     assertion failed: (replay_mutex_locked())

-- 
Alex Bennée