[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] block: Mark 'block_resize' as coroutine
From: |
Kevin Wolf |
Subject: |
Re: [PATCH 2/4] block: Mark 'block_resize' as coroutine |
Date: |
Mon, 13 Jan 2020 18:10:09 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 13.01.2020 um 17:56 hat Stefan Hajnoczi geschrieben:
> On Thu, Jan 09, 2020 at 07:35:43PM +0100, Kevin Wolf wrote:
> > block_resize is safe to run in a coroutine, so use it as an example for
> > the new 'coroutine': true annotation in the QAPI schema.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > qapi/block-core.json | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index 7ff5e5edaf..1dbb2a9901 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -1341,7 +1341,8 @@
> > { 'command': 'block_resize',
> > 'data': { '*device': 'str',
> > '*node-name': 'str',
> > - 'size': 'int' } }
> > + 'size': 'int' },
> > + 'coroutine': true }
> >
> > ##
> > # @NewImageMode:
>
> coroutine_fn is missing on
> blockdev.c:void qmp_block_resize(bool has_device, const char *device,
It wouldn't even be true until after patch 4. Should I reorder the
patches so I can add coroutine_fn?
Kevin
signature.asc
Description: PGP signature
- [PATCH 0/4] qmp: Optionally run handlers in coroutines, Kevin Wolf, 2020/01/09
- [PATCH 1/4] qapi: Add a 'coroutine' flag for commands, Kevin Wolf, 2020/01/09
- [PATCH 3/4] vl: Initialise main loop earlier, Kevin Wolf, 2020/01/09
- [PATCH 4/4] qmp: Move dispatcher to a coroutine, Kevin Wolf, 2020/01/09
- Re: [PATCH 0/4] qmp: Optionally run handlers in coroutines, Marc-André Lureau, 2020/01/13