|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH v2 3/3] savevm: check RAM is pagesize aligned |
Date: | Fri, 3 Jan 2020 08:43:37 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 1/3/20 8:40 AM, Marc-André Lureau wrote:
Check the host pointer is correctly aligned, otherwise we may fail during migration in ram_block_discard_range(). Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
--- migration/savevm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index a71b930b91..bbb7e89682 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2910,6 +2910,11 @@ err_drain:void vmstate_register_ram(MemoryRegion *mr, DeviceState *dev){ + RAMBlock *rb = mr->ram_block; + + assert(QEMU_PTR_IS_ALIGNED(qemu_ram_get_host_addr(rb), + qemu_ram_pagesize(rb))); + qemu_ram_set_idstr(mr->ram_block, memory_region_name(mr), dev); qemu_ram_set_migratable(mr->ram_block);
[Prev in Thread] | Current Thread | [Next in Thread] |