[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] tpm-ppi: page-align PPI RAM

From: Stefan Berger
Subject: Re: [PATCH v2 2/3] tpm-ppi: page-align PPI RAM
Date: Fri, 3 Jan 2020 11:38:18 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1

On 1/3/20 5:02 AM, Dr. David Alan Gilbert wrote:
* Marc-André Lureau (address@hidden) wrote:
post-copy migration fails on destination with error such as:
2019-12-26T10:22:44.714644Z qemu-kvm: ram_block_discard_range:
Unaligned start address: 0x559d2afae9a0
Ah good, we got a sane error message!

Use qemu_memalign() to constrain the PPI RAM memory alignment.

Cc: address@hidden
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
  hw/tpm/tpm_ppi.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/tpm/tpm_ppi.c b/hw/tpm/tpm_ppi.c
index ff314592b4..6d9c1a3e40 100644
--- a/hw/tpm/tpm_ppi.c
+++ b/hw/tpm/tpm_ppi.c
@@ -43,7 +43,8 @@ void tpm_ppi_reset(TPMPPI *tpmppi)
  void tpm_ppi_init(TPMPPI *tpmppi, struct MemoryRegion *m,
                    hwaddr addr, Object *obj)
-    tpmppi->buf = g_malloc0(HOST_PAGE_ALIGN(TPM_PPI_ADDR_SIZE));
+    tpmppi->buf = qemu_memalign(qemu_real_host_page_size,
+                                HOST_PAGE_ALIGN(TPM_PPI_ADDR_SIZE));
Reviewed-by: Dr. David Alan Gilbert <address@hidden>

Reviewed-by: Stefan Berger <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]