[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/28] target/s390x: Include tcg.h in mem_helper.c
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 09/28] target/s390x: Include tcg.h in mem_helper.c |
Date: |
Fri, 20 Dec 2019 17:43:11 +0000 |
User-agent: |
mu4e 1.3.5; emacs 27.0.50 |
Richard Henderson <address@hidden> writes:
> Code movement in an upcoming patch will show that this file
> was implicitly depending on tcg.h being included indirectly.
>
> Reviewed-by: David Hildenbrand <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target/s390x/mem_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
> index 2325767f17..57ce17c252 100644
> --- a/target/s390x/mem_helper.c
> +++ b/target/s390x/mem_helper.c
> @@ -27,6 +27,7 @@
> #include "exec/cpu_ldst.h"
> #include "qemu/int128.h"
> #include "qemu/atomic128.h"
> +#include "tcg.h"
>
> #if !defined(CONFIG_USER_ONLY)
> #include "hw/s390x/storage-keys.h"
--
Alex Bennée
- Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line, (continued)
- [PATCH v2 05/28] translator: Use cpu_ld*_code instead of open-coding, Richard Henderson, 2019/12/16
- [PATCH v2 06/28] cputlb: Rename helper_ret_ld*_cmmu to cpu_ld*_code, Richard Henderson, 2019/12/16
- [PATCH v2 07/28] cputlb: Provide cpu_(ld, st}*_mmuidx_ra for user-only, Richard Henderson, 2019/12/16
- [PATCH v2 08/28] target/i386: Use cpu_*_mmuidx_ra instead of templates, Richard Henderson, 2019/12/16
- [PATCH v2 09/28] target/s390x: Include tcg.h in mem_helper.c, Richard Henderson, 2019/12/16
- Re: [PATCH v2 09/28] target/s390x: Include tcg.h in mem_helper.c,
Alex Bennée <=
- [PATCH v2 10/28] target/arm: Include tcg.h in sve_helper.c, Richard Henderson, 2019/12/16
- [PATCH v2 11/28] accel/tcg: Include tcg.h in tcg-runtime.c, Richard Henderson, 2019/12/16
- [PATCH v2 13/28] linux-user: Include trace-root.h in syscall-trace.h, Richard Henderson, 2019/12/16
- [PATCH v2 12/28] linux-user: Include tcg.h in syscall.c, Richard Henderson, 2019/12/16
- [PATCH v2 15/28] target/nios2: Remove MMU_MODE{0,1}_SUFFIX, Richard Henderson, 2019/12/16
- [PATCH v2 14/28] cputlb: Expand cpu_ldst_useronly_template.h in user-exec.c, Richard Henderson, 2019/12/16