Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

[Philippe Mathieu-Daudé]

Hi Marc-André,

On 12/11/19 1:01 PM, Marc-André Lureau wrote:
> Hi
>
> On Sun, Dec 1, 2019 at 2:19 PM Marc-André Lureau
> <address@hidden> wrote:
> > - "chardev: generate an internal id when none given"
> >
> > As explained, this is necessary for qdev_prop_set_chr()
>
> ping
>
> > - "serial: register vmsd with DeviceClass"
> >
> > This is standard qdev-ification, however it breaks backward migration,
> > but that's just how qdev_set_legacy_instance_id() works.
>
> See thread, someone could review or nack (if backward migration is a problem).
>
> > - "sm501: make SerialMM a child, export chardev property"
> >
> > review?
>
> ping

This would be simpler you include "hw/display/sm501: Always map the 
UART0" previous your changes.

To finish the serial QOM-ification, we need to make serial_reset a 
DeviceReset, then we can remove the qemu_register_reset() call.

> > - "qdev/qom: remove some TODO limitations now that PROP_PTR is gone"
> >
> > This should be straightforward.
>
> ping