[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

From: Marc-André Lureau
Subject: Re: [PATCH v6 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR
Date: Sun, 1 Dec 2019 19:35:39 +0400

Hi Aleksandar

On Sun, Dec 1, 2019 at 4:15 PM Aleksandar Markovic
<address@hidden> wrote:
> On Sunday, December 1, 2019, Marc-André Lureau <address@hidden> wrote:
>> - "RFC: mips/cps: fix setting saar property"
>> Perhaps I should have used FIX instead of RFC, because this should
>> actually be a real fix. However I could use someone help to exercise
>> the code path.
> Marc-André, hi.
> There is a work in progress on fixing this. Can we in MIPS submit the fix 
> independently, since it involves some additional pieces of code that are 
> really deeply mips-specific? We acknowledge the bug, and want to develop the 
> real solution. Can you simply skip this RFC patch in your series, since the 
> issues will be handled separately in our patch, hopefully soon after the 
> merge window is open?
> For all other mips parts of your series, you have my "reviewed-by"s , in case 
> I forgot to send them explicitely.

This is a one-liner, and it is required to achieve the goal of the
series, to remove PROP_PTR.

If you prefer, I can instead comment the line with a FIXME, since it
is apparently broken anyway?

If you manage to get your fix merged earlier, then this patch can be
dropped. Else, is it a problem for the later fixes?


Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]