[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 08/21] 9pfs: well form error hint helpers

From: Markus Armbruster
Subject: Re: [PATCH v8 08/21] 9pfs: well form error hint helpers
Date: Tue, 10 Dec 2019 08:29:06 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Vladimir Sementsov-Ogievskiy <address@hidden> writes:

> Make error_append_security_model_hint and
> error_append_socket_sockfd_hint hint append helpers well formed:
> switch errp paramter to Error *const * type, as it has uncommon
> behavior: not change the pointer to return error, but operate on
> already existent error object.
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Acked-by: Greg Kurz <address@hidden>

Let's adapt PATCH 03's commit message, like this:

    9pfs: make Error **errp const where it is appropriate

    Mostly, Error ** is for returning error from the function, so the
    callee sets it. However error_append_security_model_hint and
    error_append_socket_sockfd_hint get already filled errp
    parameter. They don't change the pointer itself, only change the
    internal state of referenced Error object. So we can make it Error
    *const * errp, to stress the behavior. It will also help coccinelle
    script (in future) to distinguish such cases from common errp usage.

With something like that:
Reviewed-by: Markus Armbruster <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]