[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6] nbd: well form nbd_iter_channel_error errp handler
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH v6] nbd: well form nbd_iter_channel_error errp handler |
Date: |
Wed, 27 Nov 2019 20:07:43 +0000 |
27.11.2019 22:49, Eric Blake wrote:
> [adding Markus]
>
> On 11/27/19 1:08 PM, Vladimir Sementsov-Ogievskiy wrote:
>> Make nbd_iter_channel_error errp handler well formed:
>> rename local_err to errp_in, as it is IN-parameter here (which is
>> unusual for Error**).
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> ---
>>
>> v6: fix commit message
>> add Eric's r-b
>
> I'm surprised that you aren't including Markus on a lot of these patches -
> even though you've posted a lot of them as separate threads to make them
> easier for individual maintainers to pick up, it would also be possible for
> Markus to pick up a bunch of them at once through his error tree.
Oops, you are right, I'm sorry :(
If it helps, all patches Eric saying about are 21 patches from myself,
with v6 tag, sent during last two hours.
Sorry that I didn't answer to
https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg03105.html
before sending them, and I don't want do it now, to not move v5 above v6.
Week passed since my proposal at that link, so having one against (Eric)
and two for (Kevin and Greg), I decided to follow my plan now.
>
> At any rate, I'll queue this one through my NBD tree for 5.0 if it does not
> make it through Markus' error tree or the trivial tree sooner.
>
>
Thanks!
--
Best regards,
Vladimir