Re: [PATCH] pseries: disable migration-test if /dev/kvm cannot be used

[Laurent Vivier]

Le 21/11/2019 à 09:30, Juan Quintela a écrit :
> Laurent Vivier <address@hidden> wrote:
>> On 21/11/2019 08:18, Juan Quintela wrote:
>>> Laurent Vivier <address@hidden> wrote:
>>>> On ppc64, migration-test only works with kvm_hv, and we already
>>>> have a check to verify the module is loaded.
>>>>
>>>> kvm_hv module can be loaded in memory and /sys/module/kvm_hv exists,
>>>> but on some systems (like build systems) /dev/kvm can be missing
>>>> (by administrators choice).
>>>>
>>>> And as kvm_hv exists test-migration is started but QEMU falls back to
>>>> TCG because it cannot be used:
>>>>
>>>>     Could not access KVM kernel module: No such file or directory
>>>>     failed to initialize KVM: No such file or directory
>>>>     Back to tcg accelerator
>>>>
>>>> And as the test is done with TCG, it fails.
>>>>
>>>> As for s390x, we must check for the existence and the access rights
>>>> of /dev/kvm.
>>>>
>>>> Reported-by: Cole Robinson <address@hidden>
>>>> Signed-off-by: Laurent Vivier <address@hidden>
>>>
>>> Reviewed-by: Juan Quintela <address@hidden>
>>>
>>> Oh, why it is so difficult!!!
>>>
>>> Thanks, Juan.
>>>
>>
>> David,
>>
>> could you add this one too to your ppc-for-4.2 queue?
> 
> I was about to ask if you preffered it to go through the migration tree.
> 
> David?
> 
> Later, Juan.

Juan, as it's a fix it should go in rc3.

Thanks,
Laurent