[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/6] tests/vm: use console_consume for netbsd
From: |
Alex Bennée |
Subject: |
Re: [PATCH v1 3/6] tests/vm: use console_consume for netbsd |
Date: |
Mon, 04 Nov 2019 19:43:04 +0000 |
User-agent: |
mu4e 1.3.5; emacs 27.0.50 |
Philippe Mathieu-Daudé <address@hidden> writes:
> Hi Alex,
>
> On 11/4/19 6:36 PM, Alex Bennée wrote:
>> From: Gerd Hoffmann <address@hidden>
>> Use new helper to read all pending console output,
>> not just a single char. Unblocks installer boot.
>
> Again, why not use this by default for everything?
I thought that has already got merged via other updates. Will double
check.
>
> Anyway,
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
>
>> Signed-off-by: Gerd Hoffmann <address@hidden>
>> Message-Id: <address@hidden>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>> tests/vm/netbsd | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
>> index 5e04dcd9b16..d1bccccfd01 100755
>> --- a/tests/vm/netbsd
>> +++ b/tests/vm/netbsd
>> @@ -93,7 +93,7 @@ class NetBSDVM(basevm.BaseVM):
>> for char in list("5consdev com0\n"):
>> time.sleep(0.2)
>> self.console_send(char)
>> - self.console_wait("")
>> + self.console_consume()
>> self.console_wait_send("> ", "boot\n")
>> self.console_wait_send("Terminal type",
>> "xterm\n")
>>
--
Alex Bennée
- [PATCH v1 0/6] testing/next (netbsd stuff), Alex Bennée, 2019/11/04
- [PATCH v1 2/6] tests/vm: add console_consume helper, Alex Bennée, 2019/11/04
- [PATCH v1 4/6] tests/vm: update netbsd to version 8.1, Alex Bennée, 2019/11/04
- [PATCH v1 3/6] tests/vm: use console_consume for netbsd, Alex Bennée, 2019/11/04
- [PATCH v1 1/6] tests/vm: netbsd autoinstall, using serial console, Alex Bennée, 2019/11/04
- [PATCH v1 6/6] tests/vm: support sites with sha512 checksums, Alex Bennée, 2019/11/04
- [PATCH v1 5/6] tests: only run ipmi-bt-test if CONFIG_LINUX, Alex Bennée, 2019/11/04
- Re: [PATCH v1 0/6] testing/next (netbsd stuff), Peter Maydell, 2019/11/07