Re: [PATCH v1 3/6] tests/vm: use console_consume for netbsd

[Philippe Mathieu-Daudé]

Hi Alex,

On 11/4/19 6:36 PM, Alex Bennée wrote:
> From: Gerd Hoffmann <address@hidden>
>
> Use new helper to read all pending console output,
> not just a single char.  Unblocks installer boot.

Again, why not use this by default for everything?

Anyway,
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

> Signed-off-by: Gerd Hoffmann <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>   tests/vm/netbsd | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
> index 5e04dcd9b16..d1bccccfd01 100755
> --- a/tests/vm/netbsd
> +++ b/tests/vm/netbsd
> @@ -93,7 +93,7 @@ class NetBSDVM(basevm.BaseVM):
>           for char in list("5consdev com0\n"):
>               time.sleep(0.2)
>               self.console_send(char)
> -            self.console_wait("")
> +            self.console_consume()
>           self.console_wait_send("> ", "boot\n")
>   
>           self.console_wait_send("Terminal type",            "xterm\n")