[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 59/68] aspeed: Add an AST2600 eval board
From: |
Peter Maydell |
Subject: |
Re: [PULL 59/68] aspeed: Add an AST2600 eval board |
Date: |
Tue, 15 Oct 2019 18:03:33 +0100 |
On Mon, 14 Oct 2019 at 17:05, Peter Maydell <address@hidden> wrote:
>
> From: Cédric Le Goater <address@hidden>
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> Reviewed-by: Joel Stanley <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> include/hw/arm/aspeed.h | 1 +
> hw/arm/aspeed.c | 23 +++++++++++++++++++++++
> 2 files changed, 24 insertions(+)
> @@ -455,6 +467,17 @@ static const AspeedBoardConfig aspeed_boards[] = {
> .num_cs = 2,
> .i2c_init = witherspoon_bmc_i2c_init,
> .ram = 512 * MiB,
> + }, {
> + .name = MACHINE_TYPE_NAME("ast2600-evb"),
> + .desc = "Aspeed AST2600 EVB (Cortex A7)",
> + .soc_name = "ast2600-a0",
> + .hw_strap1 = AST2600_EVB_HW_STRAP1,
> + .hw_strap2 = AST2600_EVB_HW_STRAP2,
> + .fmc_model = "w25q512jv",
> + .spi_model = "mx66u51235f",
> + .num_cs = 1,
> + .i2c_init = ast2600_evb_i2c_init,
> + .ram = 2 * GiB,
Hi. I just discovered that this makes 'make check' fail on
32-bit systems, because you can't default to 2GB of RAM
for a board:
(armhf)pmaydell@mustang-maydell:~/qemu$
./build/all-a32/arm-softmmu/qemu-system-arm -M ast2600-evb
qemu-system-arm: at most 2047 MB RAM can be simulated
It's also a pretty rudely large amount of RAM to allocate
by default: it caused 'make check' to fail on my OSX
box, which is 64-bits but doesn't have huge swathes
of free RAM.
I'm going to drop this patch from my queue and redo
the pullreq.
thanks
-- PMM
- [PULL 48/68] aspeed/sdmc: Add AST2600 support, (continued)
- [PULL 48/68] aspeed/sdmc: Add AST2600 support, Peter Maydell, 2019/10/14
- [PULL 50/68] hw: wdt_aspeed: Add AST2600 support, Peter Maydell, 2019/10/14
- [PULL 49/68] watchdog/aspeed: Introduce an object class per SoC, Peter Maydell, 2019/10/14
- [PULL 52/68] aspeed/smc: Add AST2600 support, Peter Maydell, 2019/10/14
- [PULL 51/68] aspeed/smc: Introduce segment operations, Peter Maydell, 2019/10/14
- [PULL 53/68] hw/gpio: Add in AST2600 specific implementation, Peter Maydell, 2019/10/14
- [PULL 55/68] aspeed/i2c: Add AST2600 support, Peter Maydell, 2019/10/14
- [PULL 54/68] aspeed/i2c: Introduce an object class per SoC, Peter Maydell, 2019/10/14
- [PULL 58/68] m25p80: Add support for w25q512jv, Peter Maydell, 2019/10/14
- [PULL 59/68] aspeed: Add an AST2600 eval board, Peter Maydell, 2019/10/14
- Re: [PULL 59/68] aspeed: Add an AST2600 eval board,
Peter Maydell <=
- Re: [PULL 59/68] aspeed: Add an AST2600 eval board, Philippe Mathieu-Daudé, 2019/10/16
- Re: [PULL 59/68] aspeed: Add an AST2600 eval board, Cédric Le Goater, 2019/10/16
- Re: [PULL 59/68] aspeed: Add an AST2600 eval board, Philippe Mathieu-Daudé, 2019/10/16
[PULL 56/68] aspeed: Introduce an object class per SoC, Peter Maydell, 2019/10/14
[PULL 57/68] aspeed/soc: Add AST2600 support, Peter Maydell, 2019/10/14
[PULL 60/68] aspeed: Parameterise number of MACs, Peter Maydell, 2019/10/14
[PULL 61/68] aspeed: add support for the Aspeed MII controller of the AST2600, Peter Maydell, 2019/10/14