|
From: | Richard Henderson |
Subject: | Re: [PATCH v4 06/16] cputlb: Introduce TLB_BSWAP |
Date: | Wed, 25 Sep 2019 10:36:29 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/24/19 11:25 AM, Alex Bennée wrote: >> - >> - /* The backing page may or may not require I/O. */ >> - tlb_addr &= ~TLB_WATCHPOINT; >> - if ((tlb_addr & ~TARGET_PAGE_MASK) == 0) { >> - goto do_aligned_access; >> - } >> } >> > /* We don't apply MO_BSWAP to op here because we want to > * ensure the compiler can always unfold and dead-code away > * the final load_memop in the fast path. If you try the > * you will find the assert will get you ;-) > */ I added + /* + * Keep these two load_memop separate to ensure that the compiler + * is able to fold the entire function to a single instruction. + * There is a build-time assert inside to remind you of this. ;-) + */ r~
[Prev in Thread] | Current Thread | [Next in Thread] |