Re: [PATCH v4 04/16] cputlb: Use optimize_away in load/store_helpers

[David Hildenbrand]

On 24.09.19 00:59, Richard Henderson wrote:
> Increase the current runtime assert to a compile-time assert.
> 
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  accel/tcg/cputlb.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
> index 2222b87764..e529af6d09 100644
> --- a/accel/tcg/cputlb.c
> +++ b/accel/tcg/cputlb.c
> @@ -1396,7 +1396,7 @@ load_helper(CPUArchState *env, target_ulong addr, 
> TCGMemOpIdx oi,
>          res = ldq_le_p(haddr);
>          break;
>      default:
> -        g_assert_not_reached();
> +        optimize_away();
>      }
>  
>      return res;
> @@ -1680,8 +1680,7 @@ store_helper(CPUArchState *env, target_ulong addr, 
> uint64_t val,
>          stq_le_p(haddr, val);
>          break;
>      default:
> -        g_assert_not_reached();
> -        break;
> +        optimize_away();
>      }
>  }
>  
> 

Reviewed-by: David Hildenbrand <address@hidden>

-- 

Thanks,

David / dhildenb