Re: [PULL 00/37] QAPI patches for 2019-09-24

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [PULL 00/37] QAPI patches for 2019-09-24

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Auto packing the repository for optimum performance. You may also
run "git gc" manually. See "git help gc" for more information.
Switched to a new branch 'test'
fca7965 qapi: Assert .visit() and .check_clash() run only after .check()
1dee36f qapi: Fix excessive QAPISchemaEntity.check() recursion
67296b6 qapi: Fix to .check() empty structs just once
5df7aa4 qapi: Delete useless check_exprs() code for simple union kind
9bfd443 qapi: Clean up around check_known_keys()
6f36de8 qapi: Simplify check_keys()
f4fdcc8 qapi: Normalize 'if' in check_exprs(), like other sugar
886f5a9 qapi: Fix missing 'if' checks in struct, union, alternate 'data'
1646435 qapi: Reject blank 'if' conditions in addition to empty ones
46fb782 qapi: Fix broken discriminator error messages
66f3e2f qapi: Remove null from schema language
109b4b8 qapi: Improve reporting of lexical errors
780e43a qapi: Use quotes more consistently in frontend error messages
3befc8b tests/qapi-schema: Demonstrate suboptimal lexical errors
93a6e44 tests/qapi-schema: Demonstrate insufficient 'if' checking
1ed8709 tests/qapi-schema: Demonstrate broken discriminator errors
9b5253f tests/qapi-schema: Demonstrate misleading optional tag error
e478cdf tests/qapi-schema: Delete two redundant tests
e440f86 tests/qapi-schema: Cover unknown pragma
41391c5 qapi: Tweak code to match docs/devel/qapi-code-gen.txt
8e35fe1 docs/devel/qapi-code-gen: Improve QAPI schema language doc
886b3d4 docs/devel/qapi-code-gen: Rewrite introduction to schema
d1e96d8 docs/devel/qapi-code-gen: Rewrite compatibility considerations
d5959c2 docs/devel/qapi-code-gen: Reorder sections for readability
915a37a qapi: Adjust frontend errors to say enum value, not member
6538fc9 qapi: Permit omitting all flat union branches
417683b qapi: Permit alternates with just one branch
35d1a1a qapi: Permit 'boxed' with empty type
ad5a002 qapi: Drop support for escape sequences other than \\
37e2210 qapi: Restrict strings to printable ASCII
e95c677 tests/qapi-schema: Demonstrate bad reporting of funny characters
172dafd docs/devel/qapi-code-gen: Minor specification fixes
c33926d qapi: Drop support for boxed alternate arguments
25f22f3 qapi: Drop check_type()'s redundant parameter @allow_optional
6a914ec scripts/git.orderfile: Match QAPI schema more precisely
017b60e make check-unit: use after free in test-opts-visitor
a9711ba qapi: Make visit_next_list()'s comment less confusing

=== OUTPUT BEGIN ===
1/37 Checking commit a9711ba87218 (qapi: Make visit_next_list()'s comment less 
confusing)
2/37 Checking commit 017b60eb5cb9 (make check-unit: use after free in 
test-opts-visitor)
3/37 Checking commit 6a914ec905eb (scripts/git.orderfile: Match QAPI schema 
more precisely)
4/37 Checking commit 25f22f3a0fa1 (qapi: Drop check_type()'s redundant 
parameter @allow_optional)
5/37 Checking commit c33926d14c78 (qapi: Drop support for boxed alternate 
arguments)
6/37 Checking commit 172dafd2d40d (docs/devel/qapi-code-gen: Minor 
specification fixes)
7/37 Checking commit e95c677acdb7 (tests/qapi-schema: Demonstrate bad reporting 
of funny characters)
8/37 Checking commit 37e22103c527 (qapi: Restrict strings to printable ASCII)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#110: 
new file mode 100644

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#127: FILE: tests/qapi-schema/string-code-point-127.json:2:
+{ 'command': '⌦' }
               ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#153: FILE: tests/qapi-schema/string-code-point-31.json:2:
+{ 'command': '␟' }
               ^

total: 2 errors, 1 warnings, 76 lines checked

Patch 8/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/37 Checking commit ad5a0020e820 (qapi: Drop support for escape sequences 
other than \\)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#75: 
deleted file mode 100644

total: 0 errors, 1 warnings, 53 lines checked

Patch 9/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/37 Checking commit 35d1a1a20963 (qapi: Permit 'boxed' with empty type)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#131: 
deleted file mode 100644

total: 0 errors, 1 warnings, 129 lines checked

Patch 10/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/37 Checking commit 417683ba43fa (qapi: Permit alternates with just one 
branch)
12/37 Checking commit 6538fc9fa42b (qapi: Permit omitting all flat union 
branches)
13/37 Checking commit 915a37a4eecd (qapi: Adjust frontend errors to say enum 
value, not member)
14/37 Checking commit d5959c29193e (docs/devel/qapi-code-gen: Reorder sections 
for readability)
15/37 Checking commit d1e96d83a97f (docs/devel/qapi-code-gen: Rewrite 
compatibility considerations)
16/37 Checking commit 886b3d4a9b69 (docs/devel/qapi-code-gen: Rewrite 
introduction to schema)
17/37 Checking commit 8e35fe16b761 (docs/devel/qapi-code-gen: Improve QAPI 
schema language doc)
18/37 Checking commit 41391c527ffc (qapi: Tweak code to match 
docs/devel/qapi-code-gen.txt)
19/37 Checking commit e440f8624eba (tests/qapi-schema: Cover unknown pragma)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

total: 0 errors, 1 warnings, 10 lines checked

Patch 19/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/37 Checking commit e478cdf5f30f (tests/qapi-schema: Delete two redundant 
tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
deleted file mode 100644

total: 0 errors, 1 warnings, 18 lines checked

Patch 20/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/37 Checking commit 9b5253f1cce0 (tests/qapi-schema: Demonstrate misleading 
optional tag error)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 34 lines checked

Patch 21/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/37 Checking commit 1ed8709cff6f (tests/qapi-schema: Demonstrate broken 
discriminator errors)
23/37 Checking commit 93a6e4434ee7 (tests/qapi-schema: Demonstrate insufficient 
'if' checking)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

total: 0 errors, 1 warnings, 120 lines checked

Patch 23/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/37 Checking commit 3befc8b02156 (tests/qapi-schema: Demonstrate suboptimal 
lexical errors)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 14 lines checked

Patch 24/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/37 Checking commit 780e43ac4ae8 (qapi: Use quotes more consistently in 
frontend error messages)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#164: 
new file mode 100644

total: 0 errors, 1 warnings, 146 lines checked

Patch 25/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/37 Checking commit 109b4b89f1f3 (qapi: Improve reporting of lexical errors)
27/37 Checking commit 66f3e2fdfea8 (qapi: Remove null from schema language)
28/37 Checking commit 46fb7827e670 (qapi: Fix broken discriminator error 
messages)
29/37 Checking commit 16464352bdb8 (qapi: Reject blank 'if' conditions in 
addition to empty ones)
30/37 Checking commit 886f5a9e9a15 (qapi: Fix missing 'if' checks in struct, 
union, alternate 'data')
31/37 Checking commit f4fdcc853a48 (qapi: Normalize 'if' in check_exprs(), like 
other sugar)
32/37 Checking commit 6f36de8c07ee (qapi: Simplify check_keys())
33/37 Checking commit 9bfd443bcb0a (qapi: Clean up around check_known_keys())
34/37 Checking commit 5df7aa47a9ba (qapi: Delete useless check_exprs() code for 
simple union kind)
35/37 Checking commit 67296b6e3775 (qapi: Fix to .check() empty structs just 
once)
36/37 Checking commit 1dee36ff6bf8 (qapi: Fix excessive 
QAPISchemaEntity.check() recursion)
37/37 Checking commit fca7965dc1e6 (qapi: Assert .visit() and .check_clash() 
run only after .check())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden