Re: [PULL 00/37] QAPI patches for 2019-09-24

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [PULL 00/37] QAPI patches for 2019-09-24

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
94bb71a qapi: Assert .visit() and .check_clash() run only after .check()
e235213 qapi: Fix excessive QAPISchemaEntity.check() recursion
6abca0e qapi: Fix to .check() empty structs just once
474e373 qapi: Delete useless check_exprs() code for simple union kind
e8046dc qapi: Clean up around check_known_keys()
e04348f qapi: Simplify check_keys()
88e075d qapi: Normalize 'if' in check_exprs(), like other sugar
7aa7ae2 qapi: Fix missing 'if' checks in struct, union, alternate 'data'
85793e7 qapi: Reject blank 'if' conditions in addition to empty ones
a0f2b57 qapi: Fix broken discriminator error messages
300d20c qapi: Remove null from schema language
d7b3044 qapi: Improve reporting of lexical errors
ae7d3b9 qapi: Use quotes more consistently in frontend error messages
c390bd2 tests/qapi-schema: Demonstrate suboptimal lexical errors
fc20fdc tests/qapi-schema: Demonstrate insufficient 'if' checking
06b681b tests/qapi-schema: Demonstrate broken discriminator errors
d042260 tests/qapi-schema: Demonstrate misleading optional tag error
897d892 tests/qapi-schema: Delete two redundant tests
110d38a tests/qapi-schema: Cover unknown pragma
d43d15e qapi: Tweak code to match docs/devel/qapi-code-gen.txt
128b472 docs/devel/qapi-code-gen: Improve QAPI schema language doc
0564225 docs/devel/qapi-code-gen: Rewrite introduction to schema
7596e24 docs/devel/qapi-code-gen: Rewrite compatibility considerations
2dfb8e7 docs/devel/qapi-code-gen: Reorder sections for readability
02f7e54 qapi: Adjust frontend errors to say enum value, not member
432d8bd qapi: Permit omitting all flat union branches
0dcc5f7 qapi: Permit alternates with just one branch
d6e3fbe qapi: Permit 'boxed' with empty type
888703f qapi: Drop support for escape sequences other than \\
0446d61 qapi: Restrict strings to printable ASCII
b1b7662 tests/qapi-schema: Demonstrate bad reporting of funny characters
c106539 docs/devel/qapi-code-gen: Minor specification fixes
9d585b9 qapi: Drop support for boxed alternate arguments
93e25ba qapi: Drop check_type()'s redundant parameter @allow_optional
052b3a4 scripts/git.orderfile: Match QAPI schema more precisely
e44ecb0 make check-unit: use after free in test-opts-visitor
5cf38c1 qapi: Make visit_next_list()'s comment less confusing

=== OUTPUT BEGIN ===
1/37 Checking commit 5cf38c18d9b8 (qapi: Make visit_next_list()'s comment less 
confusing)
2/37 Checking commit e44ecb08c63d (make check-unit: use after free in 
test-opts-visitor)
3/37 Checking commit 052b3a49a2f3 (scripts/git.orderfile: Match QAPI schema 
more precisely)
4/37 Checking commit 93e25bab7a23 (qapi: Drop check_type()'s redundant 
parameter @allow_optional)
5/37 Checking commit 9d585b933636 (qapi: Drop support for boxed alternate 
arguments)
6/37 Checking commit c1065396940f (docs/devel/qapi-code-gen: Minor 
specification fixes)
7/37 Checking commit b1b7662708bf (tests/qapi-schema: Demonstrate bad reporting 
of funny characters)
8/37 Checking commit 0446d6114ed7 (qapi: Restrict strings to printable ASCII)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#110: 
new file mode 100644

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#127: FILE: tests/qapi-schema/string-code-point-127.json:2:
+{ 'command': '⌦' }
               ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#153: FILE: tests/qapi-schema/string-code-point-31.json:2:
+{ 'command': '␟' }
               ^

total: 2 errors, 1 warnings, 76 lines checked

Patch 8/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/37 Checking commit 888703f31123 (qapi: Drop support for escape sequences 
other than \\)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#75: 
deleted file mode 100644

total: 0 errors, 1 warnings, 53 lines checked

Patch 9/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/37 Checking commit d6e3fbe4fa99 (qapi: Permit 'boxed' with empty type)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#131: 
deleted file mode 100644

total: 0 errors, 1 warnings, 129 lines checked

Patch 10/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/37 Checking commit 0dcc5f73a05f (qapi: Permit alternates with just one 
branch)
12/37 Checking commit 432d8bd595d7 (qapi: Permit omitting all flat union 
branches)
13/37 Checking commit 02f7e541fd74 (qapi: Adjust frontend errors to say enum 
value, not member)
14/37 Checking commit 2dfb8e7c344b (docs/devel/qapi-code-gen: Reorder sections 
for readability)
15/37 Checking commit 7596e24f1bec (docs/devel/qapi-code-gen: Rewrite 
compatibility considerations)
16/37 Checking commit 05642257c0db (docs/devel/qapi-code-gen: Rewrite 
introduction to schema)
17/37 Checking commit 128b4726448e (docs/devel/qapi-code-gen: Improve QAPI 
schema language doc)
18/37 Checking commit d43d15e7d540 (qapi: Tweak code to match 
docs/devel/qapi-code-gen.txt)
19/37 Checking commit 110d38a4a19f (tests/qapi-schema: Cover unknown pragma)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

total: 0 errors, 1 warnings, 10 lines checked

Patch 19/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/37 Checking commit 897d892dedcf (tests/qapi-schema: Delete two redundant 
tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
deleted file mode 100644

total: 0 errors, 1 warnings, 18 lines checked

Patch 20/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/37 Checking commit d042260f5405 (tests/qapi-schema: Demonstrate misleading 
optional tag error)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 34 lines checked

Patch 21/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/37 Checking commit 06b681bc7ab7 (tests/qapi-schema: Demonstrate broken 
discriminator errors)
23/37 Checking commit fc20fdc04c5b (tests/qapi-schema: Demonstrate insufficient 
'if' checking)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

total: 0 errors, 1 warnings, 120 lines checked

Patch 23/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/37 Checking commit c390bd203f6a (tests/qapi-schema: Demonstrate suboptimal 
lexical errors)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 14 lines checked

Patch 24/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/37 Checking commit ae7d3b9c8421 (qapi: Use quotes more consistently in 
frontend error messages)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#164: 
new file mode 100644

total: 0 errors, 1 warnings, 146 lines checked

Patch 25/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/37 Checking commit d7b3044af92a (qapi: Improve reporting of lexical errors)
27/37 Checking commit 300d20c4ce3c (qapi: Remove null from schema language)
28/37 Checking commit a0f2b570a4b9 (qapi: Fix broken discriminator error 
messages)
29/37 Checking commit 85793e79ac65 (qapi: Reject blank 'if' conditions in 
addition to empty ones)
30/37 Checking commit 7aa7ae279141 (qapi: Fix missing 'if' checks in struct, 
union, alternate 'data')
31/37 Checking commit 88e075d1fccb (qapi: Normalize 'if' in check_exprs(), like 
other sugar)
32/37 Checking commit e04348f20e28 (qapi: Simplify check_keys())
33/37 Checking commit e8046dc24358 (qapi: Clean up around check_known_keys())
34/37 Checking commit 474e37349da0 (qapi: Delete useless check_exprs() code for 
simple union kind)
35/37 Checking commit 6abca0e2ed33 (qapi: Fix to .check() empty structs just 
once)
36/37 Checking commit e235213891c9 (qapi: Fix excessive 
QAPISchemaEntity.check() recursion)
37/37 Checking commit 94bb71ada7d7 (qapi: Assert .visit() and .check_clash() 
run only after .check())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden