Re: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
95d8aed Acceptance tests: use avocado.utils.ssh for SSH interaction
b5d62a1 tests/acceptance: Add new test cases in linux_ssh_mips_malta.py
41b8da1 tests/acceptance: Refactor and improve reporting in 
linux_ssh_mips_malta.py
9dbf0de Acceptance test x86_cpu_model_versions: split into smaller tests
a3bdbf3 Acceptance test x86_cpu_model_versions: fix mismatches between test and 
messages
4423807 Acceptance test x86_cpu_model_versions: shutdown VMs
e3d4392 Acceptance test machine_m68k_nextcube.py: relax the error code pattern

=== OUTPUT BEGIN ===
1/7 Checking commit e3d43927ffb3 (Acceptance test machine_m68k_nextcube.py: 
relax the error code pattern)
2/7 Checking commit 44238078fcde (Acceptance test x86_cpu_model_versions: 
shutdown VMs)
3/7 Checking commit a3bdbf35dd33 (Acceptance test x86_cpu_model_versions: fix 
mismatches between test and messages)
ERROR: line over 90 characters
#25: FILE: tests/acceptance/x86_cpu_model_versions.py:283:
+                         'pc-i440fx-4.0 + Cascadelake-Server-v1 should not 
have arch-capabilities')

ERROR: line over 90 characters
#34: FILE: tests/acceptance/x86_cpu_model_versions.py:292:
+                         'pc-i440fx-4.0 + Cascadelake-Server-v2 should have 
arch-capabilities')

ERROR: line over 90 characters
#42: FILE: tests/acceptance/x86_cpu_model_versions.py:299:
+        vm.add_args('-cpu', 
'Cascadelake-Server-v1,x-force-features=on,check=off,enforce=off,+arch-capabilities')

total: 3 errors, 0 warnings, 24 lines checked

Patch 3/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/7 Checking commit 9dbf0de5f7d5 (Acceptance test x86_cpu_model_versions: split 
into smaller tests)
5/7 Checking commit 41b8da1921af (tests/acceptance: Refactor and improve 
reporting in linux_ssh_mips_malta.py)
6/7 Checking commit b5d62a1def54 (tests/acceptance: Add new test cases in 
linux_ssh_mips_malta.py)
7/7 Checking commit 95d8aed259c8 (Acceptance tests: use avocado.utils.ssh for 
SSH interaction)
WARNING: line over 80 characters
#126: FILE: tests/acceptance/linux_ssh_mips_malta.py:85:
+        stdout_lines = [line.rstrip() for line in 
result.stdout_text.splitlines()]

WARNING: line over 80 characters
#130: FILE: tests/acceptance/linux_ssh_mips_malta.py:88:
+        stderr_lines = [line.rstrip() for line in 
result.stderr_text.splitlines()]

total: 0 errors, 2 warnings, 158 lines checked

Patch 7/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden