[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/7] Acceptance test x86_cpu_model_versions: shutdown VMs
From: |
Cleber Rosa |
Subject: |
[PULL 2/7] Acceptance test x86_cpu_model_versions: shutdown VMs |
Date: |
Mon, 23 Sep 2019 09:40:14 -0400 |
This shuts down the VMs that won't be used any longer during the
remainder of the test.
It's debatable if the very last one should also be shutdown manually,
and my opinion is that it shouldn't because that's taken care by the
immediately following tearDown().
Signed-off-by: Cleber Rosa <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
tests/acceptance/x86_cpu_model_versions.py | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/acceptance/x86_cpu_model_versions.py
b/tests/acceptance/x86_cpu_model_versions.py
index 1c9fd6a56e..e6c76b0d4c 100644
--- a/tests/acceptance/x86_cpu_model_versions.py
+++ b/tests/acceptance/x86_cpu_model_versions.py
@@ -243,6 +243,7 @@ class X86CPUModelAliases(avocado_qemu.Test):
vm.launch()
self.assertFalse(get_cpu_prop(vm, 'arch-capabilities'),
'pc-i440fx-4.1 + Cascadelake-Server should not have
arch-capabilities')
+ vm.shutdown()
vm = self.get_vm()
vm.add_args('-S')
@@ -251,6 +252,7 @@ class X86CPUModelAliases(avocado_qemu.Test):
vm.launch()
self.assertFalse(get_cpu_prop(vm, 'arch-capabilities'),
'pc-i440fx-4.0 + Cascadelake-Server should not have
arch-capabilities')
+ vm.shutdown()
# command line must override machine-type if CPU model is not
versioned:
vm = self.get_vm()
@@ -260,6 +262,7 @@ class X86CPUModelAliases(avocado_qemu.Test):
vm.launch()
self.assertTrue(get_cpu_prop(vm, 'arch-capabilities'),
'pc-i440fx-4.0 + Cascadelake-Server,+arch-capabilities
should have arch-capabilities')
+ vm.shutdown()
vm = self.get_vm()
vm.add_args('-S')
@@ -268,6 +271,7 @@ class X86CPUModelAliases(avocado_qemu.Test):
vm.launch()
self.assertFalse(get_cpu_prop(vm, 'arch-capabilities'),
'pc-i440fx-4.1 +
Cascadelake-Server,-arch-capabilities should not have arch-capabilities')
+ vm.shutdown()
# versioned CPU model overrides machine-type:
vm = self.get_vm()
@@ -277,6 +281,7 @@ class X86CPUModelAliases(avocado_qemu.Test):
vm.launch()
self.assertFalse(get_cpu_prop(vm, 'arch-capabilities'),
'pc-i440fx-4.1 + Cascadelake-Server-v1 should not
have arch-capabilities')
+ vm.shutdown()
vm = self.get_vm()
vm.add_args('-S')
@@ -285,6 +290,7 @@ class X86CPUModelAliases(avocado_qemu.Test):
vm.launch()
self.assertTrue(get_cpu_prop(vm, 'arch-capabilities'),
'pc-i440fx-4.1 + Cascadelake-Server-v1 should have
arch-capabilities')
+ vm.shutdown()
# command line must override machine-type and versioned CPU model:
vm = self.get_vm()
@@ -294,6 +300,7 @@ class X86CPUModelAliases(avocado_qemu.Test):
vm.launch()
self.assertTrue(get_cpu_prop(vm, 'arch-capabilities'),
'pc-i440fx-4.0 +
Cascadelake-Server-v1,+arch-capabilities should have arch-capabilities')
+ vm.shutdown()
vm = self.get_vm()
vm.add_args('-S')
--
2.21.0
- [PULL 0/7] Python (acceptance tests) queue - 2019-09-23, Cleber Rosa, 2019/09/23
- [PULL 1/7] Acceptance test machine_m68k_nextcube.py: relax the error code pattern, Cleber Rosa, 2019/09/23
- [PULL 2/7] Acceptance test x86_cpu_model_versions: shutdown VMs,
Cleber Rosa <=
- [PULL 3/7] Acceptance test x86_cpu_model_versions: fix mismatches between test and messages, Cleber Rosa, 2019/09/23
- [PULL 4/7] Acceptance test x86_cpu_model_versions: split into smaller tests, Cleber Rosa, 2019/09/23
- [PULL 5/7] tests/acceptance: Refactor and improve reporting in linux_ssh_mips_malta.py, Cleber Rosa, 2019/09/23
- [PULL 6/7] tests/acceptance: Add new test cases in linux_ssh_mips_malta.py, Cleber Rosa, 2019/09/23
- [PULL 7/7] Acceptance tests: use avocado.utils.ssh for SSH interaction, Cleber Rosa, 2019/09/23
- Re: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23, no-reply, 2019/09/23
- Re: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23, no-reply, 2019/09/23
- Re: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23, no-reply, 2019/09/24
- Re: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23, Peter Maydell, 2019/09/24