[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] rcu: Add automatically released rcu_read
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] rcu: Add automatically released rcu_read_lock variant |
|
Date: |
Fri, 13 Sep 2019 09:13:30 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 12/09/19 19:45, Dr. David Alan Gilbert wrote:
> Do you think it's best to use the block version for all cases
> or to use the non-block version by taste?
> The block version is quite nice, but that turns most of the patches
> into 'indent everything'.
I don't really know myself.
On first glance I didn't like too much the non-block version and thought
it was because our coding standards does not include variables declared
in the middle of a block. However, I think what really bothering me is
"AUTO" in the name. What do you think about "RCU_READ_LOCK_GUARD()"?
The block version would have the additional prefix "WITH_".
We could also add LOCK_GUARD(lock) and WITH_LOCK_GUARD(lock), using
QemuLockable for polymorphism. I even had patches a while ago (though
they used something like LOCK_GUARD(guard_var, lock). I think we
dropped them because of fear that the API was a bit over-engineered.
Paolo
[Qemu-devel] [PATCH v2 2/5] migration: Use automatic rcu_read unlock in ram.c, Dr. David Alan Gilbert (git), 2019/09/11
[Qemu-devel] [PATCH v2 3/5] migration: Use automatic rcu_read unlock in rdma.c, Dr. David Alan Gilbert (git), 2019/09/11
[Qemu-devel] [PATCH v2 5/5] migration: Missing rcu_read_unlock, Dr. David Alan Gilbert (git), 2019/09/11
[Qemu-devel] [PATCH v2 4/5] rcu: Use automatic rc_read unlock in core memory/exec code, Dr. David Alan Gilbert (git), 2019/09/11