[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/5] migration: Missing rcu_read_unlock
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/5] migration: Missing rcu_read_unlock |
Date: |
Thu, 12 Sep 2019 14:32:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 11/09/19 21:06, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Error path missing an unlock.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/ram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 1bb82acfe0..977172ea7e 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -3445,6 +3445,7 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
> RAMBLOCK_FOREACH_MIGRATABLE(block) {
> if (!block->idstr[0]) {
> error_report("%s: RAMBlock with empty name", __func__);
> + rcu_read_unlock();
> return -1;
> }
> qemu_put_byte(f, strlen(block->idstr));
>
(The scoped version would be useful here).
Paolo
- Re: [Qemu-devel] [PATCH v2 1/5] rcu: Add automatically released rcu_read_lock variant, (continued)
[Qemu-devel] [PATCH v2 2/5] migration: Use automatic rcu_read unlock in ram.c, Dr. David Alan Gilbert (git), 2019/09/11
[Qemu-devel] [PATCH v2 3/5] migration: Use automatic rcu_read unlock in rdma.c, Dr. David Alan Gilbert (git), 2019/09/11
[Qemu-devel] [PATCH v2 5/5] migration: Missing rcu_read_unlock, Dr. David Alan Gilbert (git), 2019/09/11
[Qemu-devel] [PATCH v2 4/5] rcu: Use automatic rc_read unlock in core memory/exec code, Dr. David Alan Gilbert (git), 2019/09/11