|
From: | Guoheyi |
Subject: | [Qemu-devel] hw/vfio/pci: duplicated invocation of vfio_msix_vector_release() in vfio_msix_disable() |
Date: | Tue, 10 Sep 2019 19:01:22 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 |
Hi folks,Recently we found there are 2 invocations of vfio_msix_vector_release() in vfio_msix_disable(). The 1st one is in msix_unset_vector_notifiers(), for we set device's msix_vector_release_notifier to vfio_msix_vector_release() in vfio_msix_enable(), while the 2nd is the explicit one in vfio_msix_disable(). Both invocations switch VFIO to use the non-bypass eventfd.
Is there any special reason for doing this? Or can we remove one of them? Thanks, Heyi
[Prev in Thread] | Current Thread | [Next in Thread] |