[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] Alignment checks cleanup
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] Alignment checks cleanup |
Date: |
Tue, 10 Sep 2019 12:42:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 27.08.19 20:59, Nir Soffer wrote:
> While working on 4k support, I noticed that there is lot of code using
> BDRV_SECTOR_SIZE (512) for checking alignment. I wonder how this can work with
> 4k storage.
>
> Lets start by cleaning up to make the code easier to understand:
> - Use QEMU_IS_ALIGNED macro to check alignment
> - Remove unneeded masks based on BDRV_SECTOR_SIZE
>
> Nir Soffer (2):
> block: Use QEMU_IS_ALIGNED
> block: Remove unused masks
>
> block/bochs.c | 4 ++--
> block/cloop.c | 4 ++--
> block/dmg.c | 4 ++--
> block/io.c | 8 ++++----
> block/qcow2-cluster.c | 4 ++--
> block/qcow2.c | 4 ++--
> block/vvfat.c | 8 ++++----
> include/block/block.h | 2 --
> migration/block.c | 2 +-
> qemu-img.c | 2 +-
> 10 files changed, 20 insertions(+), 22 deletions(-)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
(I think you should check the setting of git config’s user.email in your
qemu directory. Even if you send the patches through a gmail address
(which I don’t quite know why you’re doing that, but it isn’t like that
really matters), the patches should then still contain a “From: ” that
shows the actual author as set by user.name and user.email.)
Max
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 0/2] Alignment checks cleanup,
Max Reitz <=