[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages |
Date: |
Mon, 9 Sep 2019 18:00:39 +0200 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Thu, Sep 05, 2019 at 10:28:33PM +0200, Johannes Berg wrote:
>
> > +``VHOST_USER_VQ_CALL``
> > + :id: 34
> > + :equivalent ioctl: N/A
> > + :slave payload: vring state description
> > + :master payload: N/A
>
> Oops. This message should be called VHOST_USER_VRING_KICK.
>
> This file doesn't take about virtqueues, just vrings, and I inverted the
> call/kick.
>
> [...]
>
> > +``VHOST_USER_VQ_KICK``
> > + :id: 4
> > + :equivalent ioctl: N/A
> > + :slave payload: vring state description
> > + :master payload: N/A
>
> Similarly, that should be called VHOST_USER_SLAVE_VRING_CALL.
>
> Anyway, some comments would be appreciated. I'm working on an
> implementation now for my simulation environment, and I guess I can keep
> that private etc. but if there's interest I can submit an (optional)
> implementation of this for libvhost-user too, I think.
Is this really necessary? Can the simulation interpose between the
call/kick eventfds in order to control when events happen?
CPU --cpu_kickfd--> Simulation --vhost_kickfd--> vhost-user device
and:
vhost-user device --vhost_callfd--> Simulation -->cpu_callfd-> CPU
The simluation controls when the CPU's kick is seen by the device and
also when the call is seen by the CPU.
I don't understand why new vhost-user protocol messages are required.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [RFC] vhost-user simulation extension, Johannes Berg, 2019/09/02
- [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Johannes Berg, 2019/09/02
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Johannes Berg, 2019/09/05
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Johannes Berg, 2019/09/09
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Stefan Hajnoczi, 2019/09/10
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Johannes Berg, 2019/09/10
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Michael S. Tsirkin, 2019/09/10
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Johannes Berg, 2019/09/10
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Stefan Hajnoczi, 2019/09/11
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Stefan Hajnoczi, 2019/09/11
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Johannes Berg, 2019/09/11
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Stefan Hajnoczi, 2019/09/11
Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, Stefan Hajnoczi, 2019/09/11