[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 17/23] hw/i386: also turn off VMMOUSE is VMPO
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 17/23] hw/i386: also turn off VMMOUSE is VMPORT is disabled |
Date: |
Mon, 22 Jul 2019 22:02:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/17/19 3:43 PM, Alex Bennée wrote:
> Commit 97fd1ea8c1 broke the build for --without-default-devices as
> VMMOUSE depends on VMPORT.
>
> Fixes: 97fd1ea8c1
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> hw/i386/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index b9c96ac361e..6350438036f 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -52,6 +52,7 @@ config I440FX
> bool
> imply E1000_PCI
> imply VMPORT
> + imply VMMOUSE
> select PC_PCI
> select PC_ACPI
> select ACPI_SMBUS
> @@ -59,7 +60,6 @@ config I440FX
> select IDE_PIIX
> select DIMM
> select SMBIOS
> - select VMMOUSE
> select FW_CFG_DMA
>
> config ISAPC
> @@ -78,6 +78,7 @@ config Q35
> imply AMD_IOMMU
> imply E1000E_PCI_EXPRESS
> imply VMPORT
> + imply VMMOUSE
> select PC_PCI
> select PC_ACPI
> select PCI_EXPRESS_Q35
> @@ -85,7 +86,6 @@ config Q35
> select AHCI_ICH9
> select DIMM
> select SMBIOS
> - select VMMOUSE
> select FW_CFG_DMA
>
> config VTD
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- [Qemu-devel] [PATCH v2 04/23] tests/docker: Install Sphinx in the Fedora image, (continued)
- [Qemu-devel] [PATCH v2 04/23] tests/docker: Install Sphinx in the Fedora image, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 06/23] tests/migration-test: don't spam the logs when we fail, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 08/23] shippable: re-enable the windows cross builds, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 07/23] tests/dockerfiles: update the win cross builds to stretch, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 09/23] tests/docker: Install Sphinx in the Debian images, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 10/23] tests/docker: Install the NSIS tools in the MinGW capable images, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 12/23] tests/docker: Install texinfo in the Fedora image, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 11/23] tests/docker: Set the correct cross-PKG_CONFIG_PATH in the MXE images, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 17/23] hw/i386: also turn off VMMOUSE is VMPORT is disabled, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 18/23] travis: enable travis_retry for check phase, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 20/23] tests/qemu-iotests/check: Allow tests without groups, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 14/23] buildsys: The NSIS Windows build requires qemu-nsis.bmp installed, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 15/23] tests/docker: Let the test-mingw test generate a NSIS installer, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 13/23] buildsys: The NSIS Windows build requires the documentation installed, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 23/23] gitlab-ci: Remove qcow2 tests that are handled by "make check" already, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 22/23] tests: Run the iotests during "make check" again, Alex Bennée, 2019/07/17