|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [RISU PATCH v3 05/18] risugen_x86_memory: add module |
Date: | Sat, 20 Jul 2019 18:58:45 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 7/11/19 3:32 PM, Jan Bobek wrote: > +sub load(%) > +{ > + my (%args) = @_; > + > + @memory_opts{keys %args} = values %args; > + $memory_opts{is_write} = 0; > +} > + > +sub store(%) > +{ > + my (%args) = @_; > + > + @memory_opts{keys %args} = values %args; > + $memory_opts{is_write} = 1; > +} I was thinking maybe we should add a mem() that allows a "store => $d", which would simplify the "$d ? store(size => x) : load(size => x)" pattern. Anyway, that's incremental improvement. Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |