[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RISU PATCH v3 11/18] x86.risu: add SSE instructions
From: |
Jan Bobek |
Subject: |
Re: [Qemu-devel] [RISU PATCH v3 11/18] x86.risu: add SSE instructions |
Date: |
Mon, 22 Jul 2019 09:57:54 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 7/20/19 1:50 PM, Richard Henderson wrote:
> On 7/11/19 3:32 PM, Jan Bobek wrote:
>> +# NP 0F F7 /r: MASKMOVQ mm1, mm2
>> +MASKMOVQ SSE 00001111 11110111 \
>> + !constraints { modrm($_); $_->{modrm}{reg} &= 0b111; $_->{modrm}{reg2} &=
>> 0b111 if defined $_->{modrm}{reg2}; defined $_->{modrm}{reg2} } \
>> + !memory { load(size => 8, base => REG_RDI, rollback => 1); }
>
> This one is a store.
Yes, indeed. I was pretty sure there must be some mistakes left among
the 900+ instructions. Three cheers for code reviews!
-Jan
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [RISU PATCH v3 08/18] risugen: add command-line flag --x86_64, (continued)
- [Qemu-devel] [RISU PATCH v3 10/18] x86.risu: add MMX instructions, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 06/18] risugen_x86: add module, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 05/18] risugen_x86_memory: add module, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 11/18] x86.risu: add SSE instructions, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 01/18] risugen_common: add helper functions insnv, randint, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 07/18] risugen: allow all byte-aligned instructions, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 02/18] risugen_common: split eval_with_fields into extract_fields and eval_block, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 04/18] risugen_x86_constraints: add module, Jan Bobek, 2019/07/11