[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/4] tests/qemu-iotests/group: Remove some mo

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 2/4] tests/qemu-iotests/group: Remove some more tests from the "auto" group
Date: Tue, 16 Jul 2019 10:56:40 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

On 7/16/19 10:44 AM, Max Reitz wrote:
> On 16.07.19 17:31, Thomas Huth wrote:
>> On 16/07/2019 17.26, Max Reitz wrote:
>>> On 16.07.19 14:28, Thomas Huth wrote:
>>>> Remove some more tests from the "auto" group that either have issues
>>>> in certain environments (like macOS or FreeBSD, or on certain file systems
>>>> like ZFS or tmpfs), do not work with the qcow2 format, or that are simply
>>>> taking too much time.
>>>> Signed-off-by: Thomas Huth <address@hidden>
>>>> ---
>>>>  tests/qemu-iotests/group | 114 ++++++++++++++++++++-------------------
>>>>  1 file changed, 58 insertions(+), 56 deletions(-)
>>> I just looked through the list to see whether any of the test seems like
>>> we’d want to keep it even though it is a bit slow.  Mostly I was looking
>>> for tests that cover complex cases.
>>> 255 is the only one that seemed to fit that bill to me.  So why do you
>>> remove it?  Is it because it takes two seconds?
>> No, I removed it because it was failing on macOS:
>>  https://cirrus-ci.com/task/4860239294234624
>> ("OSError: AF_UNIX path too long" is the error, if I got that right)
> Ah, OK.  So, uh, we effectively can’t run any Python tests on macOS?

Not when our CI is set up to use super-long file names:

+  File
line 294, in launch

Is there any way to create our sockets somewhere under /tmp instead of
inside tests/qemu-iotests, so that we have a shorter filename for
sockets no matter how deep in the file hierarchy the tests themselves live?

Also, at one point, we tossed around the idea of
s/qemu-iotests/iotests/, to shave off 5 characters that don't really add

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]