qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-4.1 2/2] s390x/tcg: move fallthrough annotat


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH for-4.1 2/2] s390x/tcg: move fallthrough annotation
Date: Tue, 16 Jul 2019 17:22:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

On 7/8/19 2:54 PM, Cornelia Huck wrote:
> ...so that the compiler properly recognizes it.
> 
> Reported-by: Stefan Weil <address@hidden>
> Fixes: f180da83c039 ("s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND 
> ZERO")
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
>  target/s390x/translate_vx.inc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/s390x/translate_vx.inc.c b/target/s390x/translate_vx.inc.c
> index 7b1d31cba5cf..41d5cf869f94 100644
> --- a/target/s390x/translate_vx.inc.c
> +++ b/target/s390x/translate_vx.inc.c
> @@ -577,8 +577,8 @@ static DisasJumpType op_vllez(DisasContext *s, DisasOps 
> *o)
>              enr = 0;
>              break;
>          }
> -    default:
>          /* fallthrough */
> +    default:

Haha :)

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

>          gen_program_exception(s, PGM_SPECIFICATION);
>          return DISAS_NORETURN;
>      }
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]